Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu manager for Joomla Backend Menu #13036

Merged
merged 37 commits into from Jan 17, 2017
Merged

Menu manager for Joomla Backend Menu #13036

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5b7d6cd
Added client id column to menu_type table.
izharaazmi Oct 11, 2016
e64771a
In modal list view we currently hide client_id filter and show only s…
izharaazmi Oct 11, 2016
22232ce
Add/edit menu item redirect with clientId from list filter.
izharaazmi Oct 14, 2016
b943a34
Menu item type loading from component metadata xml or mvc not identif…
izharaazmi Oct 14, 2016
574081d
Edit menu item and create menu item set to follow client id and menu …
izharaazmi Oct 15, 2016
e410797
Adding layout metadata xml in backend to reference menu item types as…
izharaazmi Oct 21, 2016
8d2ae9f
Created each backend menu items using menu manager as a replica of ex…
izharaazmi Oct 22, 2016
4d44c25
[a11y] Protostar back to top (#12446)
brianteeman Oct 25, 2016
bf59761
Restructure mod_menu to load preset menu items as an option (default)…
izharaazmi Nov 1, 2016
5e36ec2
Disallow editing and set to home of protected menu type menu items vi…
izharaazmi Nov 2, 2016
ff2353c
Load menu items from databases in correct hierarchy. Remove any extra…
izharaazmi Nov 9, 2016
0214d76
View manifests for menu item type and related language key updates. r…
izharaazmi Nov 10, 2016
34dcfb0
Minor mistake fix.
izharaazmi Nov 11, 2016
8e54a46
Merge branch '3.7.x' into admin-menu-manager
izharaazmi Nov 11, 2016
402c7c0
Translate menu item titles in list view. Ref #2
izharaazmi Nov 11, 2016
40f913a
Reset the preset menu structure to be same as the current J37 branch …
izharaazmi Nov 17, 2016
f4a9fb6
Allow the existing components to leverage the menu/submenu entries in…
izharaazmi Nov 17, 2016
7986f86
Minor fix
izharaazmi Nov 19, 2016
694614e
Remove temporary dev phase files
izharaazmi Nov 19, 2016
059c9b6
Preparing for PR, database and install script updates.
izharaazmi Nov 19, 2016
3286409
Minor fix
izharaazmi Nov 19, 2016
de8cc97
Codestyle fix
izharaazmi Nov 27, 2016
9b8a99d
Merge branch 'staging' into admin-menu-manager
izharaazmi Dec 7, 2016
16ff8c4
CS fix
izharaazmi Dec 7, 2016
2454925
Don’t sort menu items
izharaazmi Dec 12, 2016
e8de57a
Sort lang keys
izharaazmi Dec 12, 2016
defdcdc
apply in hathor
izharaazmi Dec 12, 2016
c1e711a
menu item alias check for site only
izharaazmi Dec 12, 2016
28a835b
Merge ‘staging’ into admin-menu-manager
izharaazmi Dec 19, 2016
7d9e0bb
Merge joomla-cms/staging into admin-menu-manager
izharaazmi Jan 9, 2017
0aef9d4
Post merge fixes.
izharaazmi Jan 9, 2017
a991b7f
Fixes as suggested by @infograf768
izharaazmi Jan 9, 2017
600a6aa
Add recovery mode for menu where the selected admin menu does not con…
izharaazmi Jan 9, 2017
07a9a6a
minor bug fix
izharaazmi Jan 9, 2017
9c6f953
Merge joomla-cms/staging into admin-menu-manager
izharaazmi Jan 10, 2017
9b52f78
Remove assoc column for admin menu items.
izharaazmi Jan 10, 2017
3f1e8c5
Merge 'staging' into admin-menu-manager
izharaazmi Jan 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 14 additions & 11 deletions libraries/legacy/table/menu.php
View file
Open in desktop
Expand Up @@ -148,22 +148,25 @@ public function store($updateNulls = false)
$this->alias = !$originalAlias ? $this->title : $originalAlias;
$this->alias = JApplicationHelper::stringURLSafe(trim($this->alias), $this->language);

// Verify that a first level menu item alias is not 'component'.
if ($this->parent_id == 1 && $this->client_id == 0 && $this->alias == 'component')
if ($this->parent_id == 1 && $this->client_id == 0)
{
$this->setError(JText::_('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_COMPONENT'));
// Verify that a first level menu item alias is not 'component'.
if ( $this->alias == 'component')
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space too much after parenthesis

$this->setError(JText::_('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_COMPONENT'));

return false;
}
return false;
}

// Verify that a first level menu item alias is not the name of a folder.
jimport('joomla.filesystem.folder');
// Verify that a first level menu item alias is not the name of a folder.
jimport('joomla.filesystem.folder');

if ($this->parent_id == 1 && in_array($this->alias, JFolder::folders(JPATH_ROOT)))
{
$this->setError(JText::sprintf('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_FOLDER', $this->alias, $this->alias));
if (in_array($this->alias, JFolder::folders(JPATH_ROOT)))
{
$this->setError(JText::sprintf('JLIB_DATABASE_ERROR_MENU_ROOT_ALIAS_FOLDER', $this->alias, $this->alias));

return false;
return false;
}
}

// If alias still empty (for instance, new menu item with chinese characters with no unicode alias setting).
Expand Down