Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input-medium class in mod_search to get similar output as for mod_finder #14099

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Add input-medium class in mod_search to get similar output as for mod_finder #14099

merged 2 commits into from
Feb 23, 2017

Conversation

sanderpotjer
Copy link
Member

@sanderpotjer sanderpotjer commented Feb 15, 2017

Summary of Changes

Adding input-medium class for input field to get the same output as for mod_finder. We have had this issue for the joomla.org templates for example, where the output is different if using mod_search instead of mod_finder.

Testing Instructions

Before patch the input-medium class is not in the output for mod_search, after applying patch the output should be changed and input-medium is one of the classes.

@ghost
Copy link

ghost commented Feb 16, 2017

I have tested this item ✅ successfully on 10a5eb0

After Patch com_search (Modules: Search) have a input-medium similar to com_finder (Modules: Smart Search).

Thanks @sanderpotjer


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.

@joomdonation
Copy link
Contributor

Do we have to worry about adding input-medium class will change the display of search module on existing websites?

@ghost
Copy link

ghost commented Feb 22, 2017

@C-Lodder do we have worry about?

@C-Lodder
Copy link
Member

This is fine. The input-medium width will only kick in, if the Box Width parameter for mod_search has no value.

@C-Lodder
Copy link
Member

I have tested this item ✅ successfully on 10a5eb0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.

@dgrammatiko
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2017
@ghost
Copy link

ghost commented Feb 22, 2017

Thanks @C-Lodder @dgt41

@rdeutz
Copy link
Contributor

rdeutz commented Feb 22, 2017

unit test must be fixed before we can merge this @sanderpotjer ca you do that?

@wilsonge
Copy link
Contributor

I have fixed el unit test

@wilsonge wilsonge merged commit 153c075 into joomla:staging Feb 23, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants