-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input-medium
class in mod_search to get similar output as for mod_finder
#14099
Conversation
I have tested this item ✅ successfully on 10a5eb0 Thanks @sanderpotjer This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099. |
Do we have to worry about adding input-medium class will change the display of search module on existing websites? |
@C-Lodder do we have worry about? |
This is fine. The |
I have tested this item ✅ successfully on 10a5eb0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099. |
Thanks @C-Lodder @dgt41 |
unit test must be fixed before we can merge this @sanderpotjer ca you do that? |
I have fixed el unit test |
Summary of Changes
Adding
input-medium
class for input field to get the same output as for mod_finder. We have had this issue for the joomla.org templates for example, where the output is different if using mod_search instead of mod_finder.Testing Instructions
Before patch the
input-medium
class is not in the output for mod_search, after applying patch the output should be changed andinput-medium
is one of the classes.