[j4] Load the correct namespace when it doesn't exist #15219
Conversation
| @@ -9,7 +9,9 @@ | |||
|
|
|||
| defined('_JEXEC') or die; | |||
|
|
|||
| use Joomla\CMS\Application\CmsApplication; | |||
There was a problem hiding this comment.
Shouldnt we be using CMSApplication?
There was a problem hiding this comment.
It's the right class https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/CMS/Application/CmsApplication.php#L27. If you want to make it upper case, then a pr is needed.
There was a problem hiding this comment.
Up to others to decide but if we have /CMS/ then I believe we should have /CMSApplication/ for the same reason
There was a problem hiding this comment.
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/cms.php#L19 We have had JApplicationCms since 3.2 xD
|
I don't think this works if |
|
@wilsonge don't get you. This actually fixes the case when the entry in the database is empty. |
|
https://github.com/joomla/joomla-cms/pull/15219/files#diff-a1fc526090bccb9c6de3bd3ce800dabeR35 How can |
…amespace # Conflicts: # administrator/components/com_content/dispatcher.php
|
It is most likely |
|
I mean it is just a workaround till we have the autoloading #15226 merged, when people try out the 4.0-dev branch. |
laoneo
changed the title
The dispatcher is loading the correct namespace when it doesn't exist.