-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix + Simplify code of frontend module editing #15445
Conversation
I have tested this item ✅ successfully on dc3b333 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445. |
I have tested this item ✅ successfully on dc3b333 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445. |
Many thanks for testing @franz-wohlkoenig , @richard67 . |
Is there a reason this can't go into staging (but you'd need to leave the |
@wilsonge Only the change in display controller of com_config can go into stagging. Since we have to keep the file view.json.php, the code in module controller class will need to be kept as well Do we really need to deprecate the view.json.php class? We will namespace com_modules, so that class won't be available in Joomla4 anyway, so I think it doesn't need to be deprecated? |
@wilsonge Maybe just merge it into Joomla 4. It helps namespacing com_modules easier. We can backport the change of display controller in com_config back to staging later if needed |
Pull Request for Issue # .
Summary of Changes
com_config (frontend) has really strange code. Instead of calling backend model getItem() method to get the module data, it uses complicated code by calling controller display method to get json view data.
This PR fixes that strange code. As a result, the json view + some code in com_modules is removed, too.
Testing Instructions