Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix + Simplify code of frontend module editing #15445

Merged
merged 3 commits into from
Apr 23, 2017
Merged

[4.0] Fix + Simplify code of frontend module editing #15445

merged 3 commits into from
Apr 23, 2017

Conversation

joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Apr 21, 2017

Pull Request for Issue # .

Summary of Changes

com_config (frontend) has really strange code. Instead of calling backend model getItem() method to get the module data, it uses complicated code by calling controller display method to get json view data.

This PR fixes that strange code. As a result, the json view + some code in com_modules is removed, too.

Testing Instructions

  1. Install Joomla 4 (with sample data for easier testing)
  2. Login to frontend using a super admin account
  3. Try to edit a module
  4. Before patch, no form display to allow edit module parameters
  5. After patch, a form displayed to allow changing module parameter. Save the module data, make sure the changes parameter is saved.

@ghost
Copy link

ghost commented Apr 21, 2017

I have tested this item ✅ successfully on dc3b333


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445.

@joomla-cms-bot joomla-cms-bot changed the title [4.0] Fix + Simplify code of fontend module editing [4.0] Fix + Simplify code of frontend module editing Apr 21, 2017
@richard67
Copy link
Member

I have tested this item ✅ successfully on dc3b333


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445.

@zero-24 zero-24 added this to the Joomla 4.0 milestone Apr 21, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Apr 21, 2017
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Apr 21, 2017
@zero-24 zero-24 added this to the Joomla 4.0 milestone Apr 21, 2017
@joomdonation
Copy link
Contributor Author

Many thanks for testing @franz-wohlkoenig , @richard67 .

@wilsonge
Copy link
Contributor

Is there a reason this can't go into staging (but you'd need to leave the view.json.php in place and deprecate it for j4

@joomdonation
Copy link
Contributor Author

@wilsonge Only the change in display controller of com_config can go into stagging. Since we have to keep the file view.json.php, the code in module controller class will need to be kept as well

Do we really need to deprecate the view.json.php class? We will namespace com_modules, so that class won't be available in Joomla4 anyway, so I think it doesn't need to be deprecated?

@joomdonation
Copy link
Contributor Author

@wilsonge Maybe just merge it into Joomla 4. It helps namespacing com_modules easier. We can backport the change of display controller in com_config back to staging later if needed

@wilsonge wilsonge merged commit fa8503e into joomla:4.0-dev Apr 23, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2017
@joomdonation joomdonation deleted the fontend-module-editing branch April 23, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants