Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact page does not load proper com_user.profile XML #16461

Merged
merged 1 commit into from Jun 13, 2017

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 3, 2017

Pull Request for Issue #8120.

Summary of Changes

This adds in the right profile XML for the profile linked to a contact. See #8120 for a longer explanation.

Testing Instructions

  1. Create or edit a contact and connect it with a user.
  2. Edit the default.php layout of the contact view of com_contact and insert a var_dump($this->item);
  3. Access the contact in the frontend and see that the $this->item->profile field contains an empty JForm object.
  4. Apply the changes.
  5. See that the JForm object now contains some data from the user.
@matrikular
Copy link
Contributor

@matrikular matrikular commented Jun 3, 2017

I have tested this item successfully on dce517b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16461.

@richard67
Copy link
Member

@richard67 richard67 commented Jun 3, 2017

I have tested this item successfully on dce517b

Before patch:
... ["profile"]=> object(JForm)#444 (6) { ["data":protected]=> object(Joomla\Registry\Registry)#446 (3) { ["data":protected]=> object(stdClass)#453 (0) { } ...

After patch:
... ["profile"]=> object(JForm)#444 (6) { ["data":protected]=> object(Joomla\Registry\Registry)#446 (3) { ["data":protected]=> object(stdClass)#453 (3) { ["id"]=> string(2) ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16461.
@ghost
Copy link

@ghost ghost commented Jun 3, 2017

RTC after two successful tests.

@rdeutz rdeutz merged commit 07b93b7 into joomla:staging Jun 13, 2017
4 checks passed
4 checks passed
@joomla-cms-bot
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rdeutz rdeutz added this to the Joomla 3.7.3 milestone Jun 13, 2017
@Hackwar Hackwar deleted the Hackwar:patch-20 branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants