Improve shared session tooltip #16514
Conversation
| @@ -194,7 +194,7 @@ COM_CONFIG_FIELD_SESSION_HANDLER_DESC="The mechanism by which Joomla identifies | |||
| COM_CONFIG_FIELD_SESSION_HANDLER_LABEL="Session Handler" | |||
| COM_CONFIG_FIELD_SESSION_TIME_DESC="Auto log out a User after they have been inactive for the entered number of minutes. Do not set too high." | |||
| COM_CONFIG_FIELD_SESSION_TIME_LABEL="Session Lifetime" | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site." | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site and that, due to the use secure cookies, shared session will not work when \"Force HTTPS\" option is set to \"Administrator Only\"." | |||
There was a problem hiding this comment.
... when the "Force HTTPS" option is set to "Administrator Only"."
I think you should add the "the".
|
|
|
See #16515 |
|
I still think that "... will not work when the "Force HTTPS" option is set to ..." is better English than "... will not work when "Force HTTPS" option is set to ...". |
|
I have tested this item ✅ successfully on 69975c2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16514. |
| @@ -194,7 +194,7 @@ COM_CONFIG_FIELD_SESSION_HANDLER_DESC="The mechanism by which Joomla identifies | |||
| COM_CONFIG_FIELD_SESSION_HANDLER_LABEL="Session Handler" | |||
| COM_CONFIG_FIELD_SESSION_TIME_DESC="Auto log out a User after they have been inactive for the entered number of minutes. Do not set too high." | |||
| COM_CONFIG_FIELD_SESSION_TIME_LABEL="Session Lifetime" | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site." | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site and that, due to the use secure cookies, shared sessions will not work when the \"Force HTTPS\" option is set to \"Administrator Only\"." | |||
There was a problem hiding this comment.
please make this a new sentence. long sentences are harder to understand and introduce translation issues. It is also enough to simply add
"This will not work when Force https is set to administrator onlly
There was a problem hiding this comment.
@brianteeman can i ask you to put a better english? thanks
There was a problem hiding this comment.
+COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site. Shared sessions is not available when the "Force HTTPS" option is set to "Administrator Only"."
There was a problem hiding this comment.
Shared session is not or Shared sessions are not?
|
changed thanks @brianteeman |
|
I have tested this item ✅ successfully on f5ebae4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16514. |
| @@ -194,7 +194,7 @@ COM_CONFIG_FIELD_SESSION_HANDLER_DESC="The mechanism by which Joomla identifies | |||
| COM_CONFIG_FIELD_SESSION_HANDLER_LABEL="Session Handler" | |||
| COM_CONFIG_FIELD_SESSION_TIME_DESC="Auto log out a User after they have been inactive for the entered number of minutes. Do not set too high." | |||
| COM_CONFIG_FIELD_SESSION_TIME_LABEL="Session Lifetime" | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site." | |||
| COM_CONFIG_FIELD_SHARED_SESSION_DESC="When enabled, a user's session is shared between the frontend and administrator sections of the site. Note that changing this value will invalidate all existing sessions on the site. Shared sessions is not available when the \"Force HTTPS\" option is set to \"Administrator Only\"." | |||
There was a problem hiding this comment.
Having thought more on this it is possible that a translator will not correctly understand this - so I will have another attempt at rewording this later - please be patient and do not merge
There was a problem hiding this comment.
When the "Force HTTPS" option is set to "Administrator Only" this is not available.
There was a problem hiding this comment.
I would rephrase it This is not available when the "Force HTTPS" option is set to "Administrator Only". to let the user know sooner than later in the sentence.
|
ok corrected. please check |
|
I have tested this item ✅ successfully on 719fc31 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16514. |
1 similar comment
|
I have tested this item ✅ successfully on 719fc31 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16514. |
|
RTC after two successful tests. |
Pull Request for Issue #16485.
Summary of Changes
Improves shared session tooltip to inform users that shared session will not work when Force HTTPS is set to Administrator only.
Testing Instructions
Language review.
Expected result
Used informed.
Actual result
Used not informed.
Documentation Changes Required
None.