New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put multiple versions of the same tag #16583

Merged
merged 5 commits into from Jul 19, 2017

Conversation

Projects
None yet
8 participants
@kernusr
Contributor

kernusr commented Jun 8, 2017

Pull Request for Issue # .

Summary of Changes

Changed the type of the parameter $content from a string to an array in the setMetaData method of the JDocument class.
This will allow you to add multiple identical tags with different values. For example og:image (http://ogp.me/#array)

Testing Instructions

Call in your code
JFactory::getDocument()->setMetaData("og:image", array("/image1.jpg", "/image2.jpg", "/image3.jpg"), 'property');

Expected result

View the source of the page in the browser.
You should see the following code in head:
<meta property="og:image" content="/image1.jpg" /> <meta property="og:image" content="/image2.jpg" /> <meta property="og:image" content="/image3.jpg" />

Documentation Changes Required

https://api.joomla.org/cms-3/classes/JDocument.html#method_setMetaData
Replace this:

$content string Value of the meta HTML tag
with this:

$content mixed Value of the meta HTML tag as array or string

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 8, 2017

@kernusr can you please write the "Summary of Changes" also in English – thanks.

franz-wohlkoenig commented Jun 8, 2017

@kernusr can you please write the "Summary of Changes" also in English – thanks.

@kernusr

This comment has been minimized.

Show comment
Hide comment
@kernusr

kernusr Jun 8, 2017

Contributor

@franz-wohlkoenig oops! Sory

Contributor

kernusr commented Jun 8, 2017

@franz-wohlkoenig oops! Sory

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 22, 2017

Contributor

I have tested this item successfully on bb096d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.

Contributor

brianteeman commented Jun 22, 2017

I have tested this item successfully on bb096d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.

Quy and others added some commits Jun 22, 2017

Merge pull request #1 from Quy/patch-2
cs: Remove tabs
@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Jun 22, 2017

Contributor

I have tested this item successfully on 9ba276b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.

Contributor

Quy commented Jun 22, 2017

I have tested this item successfully on 9ba276b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Jun 22, 2017

Contributor

@franz-wohlkoenig Please RTC as the last change was to remove tabs which would not affect the test result. Thanks.

Contributor

Quy commented Jun 22, 2017

@franz-wohlkoenig Please RTC as the last change was to remove tabs which would not affect the test result. Thanks.

@joomla-cms-bot joomla-cms-bot changed the title from put multiple versions of the same <meta> tag to put multiple versions of the same tag Jun 22, 2017

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 22, 2017

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jun 22, 2017

RTC after two successful tests.

franz-wohlkoenig commented Jun 22, 2017

RTC after two successful tests.

@zero-24 zero-24 added this to the Joomla 3.7.4 milestone Jun 22, 2017

@rdeutz rdeutz modified the milestones: Joomla 3.8.0, Joomla 3.7.4 Jul 11, 2017

@mbabker mbabker changed the base branch from staging to 3.8-dev Jul 19, 2017

@mbabker mbabker merged commit 26a6239 into joomla:3.8-dev Jul 19, 2017

4 of 6 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@joomla-cms-bot joomla-cms-bot added PR-3.8-dev and removed RTC labels Jul 19, 2017

@mbabker mbabker removed the PR-staging label Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment