put multiple versions of the same tag #16583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kernusr can you please write the "Summary of Changes" also in English – thanks. |
|
@franz-wohlkoenig oops! Sory |
Quy
reviewed
Jun 12, 2017
| // B/C old http_equiv parameter. | ||
| if (!is_string($attribute)) | ||
| { | ||
| $attribute = $attribute == true ? 'http-equiv' : 'name'; | ||
| } | ||
|
|
||
|
I have tested this item ✅ successfully on bb096d5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583. |
cs: Remove tabs
|
I have tested this item ✅ successfully on 9ba276b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16583. |
|
@franz-wohlkoenig Please RTC as the last change was to remove tabs which would not affect the test result. Thanks. |
joomla-cms-bot
changed the title
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-3.8-dev
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Changed the type of the parameter $content from a string to an array in the setMetaData method of the JDocument class.
This will allow you to add multiple identical tags with different values. For example og:image (http://ogp.me/#array)
Testing Instructions
Call in your code
JFactory::getDocument()->setMetaData("og:image", array("/image1.jpg", "/image2.jpg", "/image3.jpg"), 'property');Expected result
View the source of the page in the browser.
You should see the following code in head:
<meta property="og:image" content="/image1.jpg" /> <meta property="og:image" content="/image2.jpg" /> <meta property="og:image" content="/image3.jpg" />Documentation Changes Required
https://api.joomla.org/cms-3/classes/JDocument.html#method_setMetaData
Replace this: