-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace crypt #16825
Namespace crypt #16825
Conversation
@@ -16,7 +17,7 @@ | |||
* | |||
* @since 12.1 | |||
*/ | |||
class JCryptKey | |||
class CryptKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the Framework can we just name this Key
instead?
*/ | ||
class JCryptCipher3Des extends JCryptCipherMcrypt | ||
class TrippleDesCipher extends McryptCipher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triple only has one "p" in it.
libraries/classmap.php
Outdated
|
||
JLoader::registerAlias('JCrypt', '\\Joomla\\CMS\\Crypt\\Crypt', '5.0'); | ||
JLoader::registerAlias('JCryptCipher', '\\Joomla\\CMS\\Crypt\\CipherInterface', '5.0'); | ||
JLoader::registerAlias('JCryptKey', '\\Joomla\\CMS\\Crypt\\CryptKey', '5.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the alias.
Done |
Namespace crypt. I'm aware that some classes will be skipped in J4, but for consistency I namespaced all.