Solving Notices when looking for updates #17481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me. |
|
I have tested this item ✅ successfully on fcc178b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
|
@svenbluege Could you mark your test result as success in the issue tracker https://issues.joomla.org/tracker/joomla-cms/17481 by using the "Test this" button? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
|
I did it for him already. |
|
I have tested this item ✅ successfully on fcc178b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
|
Great. Travis error seems not related to this PR. |
|
I restarted Travis. Good now. RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
added 2 commits
August 11, 2017 06:44
|
This needs retesting. There were several other changes in this PR which I have now corrected. |
|
I have tested this item ✅ successfully on 71334df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
1 similar comment
|
I have tested this item ✅ successfully on 71334df This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
|
i guess rtc for good now. 😄 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17481. |
zero-24
added a commit
to zero-24/joomla-cms
that referenced
this pull request
Aug 13, 2017
Merged
|
Looks like this now let all drone builds fail see #17526 Thanks. |
wilsonge
pushed a commit
that referenced
this pull request
Aug 14, 2017
* fix drone errors after #17481 * remove some tabs * remove some tabs * keep @Quy and @richard67 happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17452 and #17462
Testing Instructions
Install a brand new staging, look at php logs.
also when trying to Find Updates in Extensions=>Manage=>Update
And when displaying Joomla Update component.
Patch and test again.
@svenbluege @AlexRed @richard67