Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_finder] - fix warning on search when not found #17732

Merged
merged 1 commit into from
Aug 27, 2017
Merged

[com_finder] - fix warning on search when not found #17732

merged 1 commit into from
Aug 27, 2017

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Aug 27, 2017

Pull Request for Issue #17731 .

Summary of Changes

fix total check

Testing Instructions

see #17731

Expected result

no warning

Actual result

waring

@ghost
Copy link

ghost commented Aug 27, 2017

I have tested this item ✅ successfully on 1a744e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

@sandewt
Copy link
Contributor

sandewt commented Aug 27, 2017

Hi @alikon,

What do you think of:

<?php if ($this->total === 0 || $this->total === null) : ?>

Instead of:

<?php if (($this->total === 0) || ($this->total === null)) : ?>

In line 36, file ..\components\com_finder\views\search\tmpl\default_results.php ???

Gr.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

@sandewt
Copy link
Contributor

sandewt commented Aug 27, 2017

I have tested this item ✅ successfully on 1a744e7

See note above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17732.

@ghost
Copy link

ghost commented Aug 27, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 27, 2017
@mbabker mbabker added this to the Joomla 3.8.0 milestone Aug 27, 2017
@mbabker mbabker merged commit aafbe7d into joomla:staging Aug 27, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Aug 27, 2017
@alikon alikon deleted the patch-98 branch August 28, 2017 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants