Use https URLs for openstreetmap.org. #19359
Conversation
…soon, the rest is good practice
|
Thank you for this PR Please can you make it upstream at https://github.com/joomla-framework/openstreetmap-api |
|
Thanks, done! joomla-framework/openstreetmap-api#4 |
|
thank you |
|
This PR still needs to be applied here for the 3.x releases since the Framework package isn't in use. |
|
@mbabker my mistake sorry I thought we pulled the framework passage in |
| @@ -99,9 +99,9 @@ public function __construct(JOpenstreetmapOauth $oauth = null, Registry $options | |||
| $this->client = isset($client) ? $client : new JHttp($this->options); | |||
|
|
|||
| // Setup the default API url if not already set. | |||
| $this->options->def('api.url', 'http://api.openstreetmap.org/api/0.6/'); | |||
| $this->options->def('api.url', 'https://api.openstreetmap.org/api/0.6/'); | |||
There was a problem hiding this comment.
is this the correct url?
Couldn't find a file/directory/API operation by that name on the OpenStreetMap server (HTTP 404)
There was a problem hiding this comment.
Yeah, that error message isn't very helpful. It's the api base url, objects are contained in other URLs within, e.g. https://api.openstreetmap.org/api/0.6/node/3109685771
|
I have tested this item ✅ successfully on 3fc2692 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19359. |
|
I have tested this item ✅ successfully on 3fc2692 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19359. |
joomla-cms-bot
changed the title
|
Merged for 3.8.4 thanks. |
Summary of Changes
OpenStreetMap is moving to https by default and all oauth calls made to the http endpoint after that will fail. This simple PR converts all openstreetmap.org http calls to https.
While I was at it, I converted all the other openstreetmap.org URLs to use https.
No related Joomla issue, no additional tests, no documentation changes.