New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert routing changes in 3.8.4 #19512

Merged
merged 4 commits into from Feb 3, 2018

Conversation

Projects
None yet
9 participants
@csthomas
Contributor

csthomas commented Feb 1, 2018

Pull Request for Issue #19504

Summary of Changes

Because I am responsible for this, I feel that I have to prepare a reverse PR.

I'm not a fan of this PR but I won't insist to stay without reversion.

Each of reverted PRs are connected each other.

  1. Revert URL changes.
  2. Revert changes in language filter.

Expected result

The same as on 3.8.3

Actual result

New structured URLs.

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 1, 2018

Works fine. Evidently, #15730 is still an issue if no login form menu item is present.

@cavo789

This comment has been minimized.

cavo789 commented Feb 1, 2018

I have tested this item successfully on 335100c

It was impossible anymore to log in on the frontend on my multilingual website; ERR_INVALID_REDIRECT just after the submission of the log in screen. With #19512 applied, problem solved. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 1, 2018

I have tested this item successfully on 335100c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512.

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 1, 2018

@mbabker to decide

@mbabker

This comment has been minimized.

Member

mbabker commented Feb 1, 2018

Will look later when back from travel.

Because I am responsible for this, I feel that I have to prepare a reverse PR.

As the saying goes, stuff happens. Nobody's blaming you.

@infograf768

This comment has been minimized.

Member

infograf768 commented Feb 2, 2018

I have created a PR to, at least, inform users of the necessity to create a login form when Home is set to registered. #19535

@csthomas

This comment has been minimized.

Contributor

csthomas commented Feb 2, 2018

As the saying goes, stuff happens. Nobody's blaming you.

Thanks

@tonypartridge

This comment has been minimized.

Contributor

tonypartridge commented Feb 2, 2018

Good work, your not to blame. You PR was valid, the issue is the lack of people testing the 3.8.4 release.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.5 milestone Feb 3, 2018

@franz-wohlkoenig

This comment has been minimized.

franz-wohlkoenig commented Feb 3, 2018

Ready to Commit after two successful tests.

@mbabker mbabker added this to the Joomla 3.8.5 milestone Feb 3, 2018

@mbabker mbabker merged commit cb856df into joomla:staging Feb 3, 2018

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@csthomas csthomas deleted the csthomas:routing_revert branch Feb 3, 2018

@shur

This comment has been minimized.

Contributor

shur commented on plugins/system/languagefilter/languagefilter.php in 335100c Feb 6, 2018

why with a capital letter?

@shur

This comment has been minimized.

Contributor

shur commented on plugins/system/languagefilter/languagefilter.php in 335100c Feb 6, 2018

Double space

@LukeDouglas2

This comment has been minimized.

LukeDouglas2 commented Feb 7, 2018

Installed 3.8.5 on 67 websites and everything seems fine. Great work.

I wanted to compliment the development team on the work since Joomla 3 was released. Along with the Gantry Framework team, you have cut my maintenance time by at least 10% on websites. That's extra time for the golf course. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment