[4.0] Module dispatcher

[laoneo]

Summary of Changes

Introduces a ModuleDispatcher as replacement for the single entry file for modules. The workflow is then similar to components with a Dispatcher and a service provider.

A module needs then a file services/provider.php which does register the ModuleInterface::class resource in the container:

public function register(Container $container)
{
	$container->registerServiceProvider(new DispatcherFactory('\\Joomla\\Module\\MyModule'));

	$container->registerServiceProvider(new Module);
}

and a dispatcher created by the DispatcherFactory. The dispatcher can override the function getLayoutData() to provide additional data for the layout. The rest stays the same.

More information can be found in #20217 and #19667.

Testing Instructions

Open the front end.

Expected result

The Menu module should work as before.

Actual result

All is working fine.

Documentation Changes Required

Needs to be documented as with the Dispatcher for components.

[shur]

administrator/components/com_content/Dispatcher/Dispatcher.php
Is everything correct here?
Must file name start with the capital letter?

[laoneo]

Yes, that's the new approach we go, introduced by pr #19811. I will convert the rest of the core extensions when all services like Associations, etc. is done.

[laoneo]

Any more feedback?

[roland-d]

@laoneo Why is it called DefaultModuleDispatcher.php versus the ComponentDispatcher.php? I would expect a ModuleDispatcher.php?

Other than that, the consistency looks good. This PR is also so huge I think we should just start using it and see if we run into any issues :)

[laoneo]

Was a suggestion from @wilsonge to have it crystal clear that this is the default one. Having a look now, it would probably make sense to rename it back to ModuleDispatcher.php.

[roland-d]

@laoneo Just my first thought was why does that have a different name. Makes more sense to me to stick to one naming scheme.

[laoneo]

Ok, renamed it. Looks indeed more clear.

[roland-d]

@laoneo the drone failed??

[zero-24]

just rebooted the tests.

[laoneo]

Drone is failing atm all the time with a user system test. Rebooting doesn't help, the test needs to be fixed.

[wilsonge]

Thanks for being so patient on this one!

[laoneo]

Time brought a couple of good ideas.