[plg_editors_codemirror] Manifest cleanup #20544
Conversation
| @@ -71,7 +71,7 @@ | |||
| description="PLG_CODEMIRROR_FIELD_LINEWRAPPING_DESC" | |||
There was a problem hiding this comment.
This was set to hidden on purpose https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/codemirror/codemirror.php#L210-L211.
But disabling line wrapping seems to work fine now.
|
|
||
| // Add styling to the active line. | ||
| $options->styleActiveLine = (boolean) $this->params->get('activeLine', true); | ||
| $options->styleActiveLine = (boolean) $this->params->get('activeLine', 1); | ||
|
|
||
| // Add styling to the active line. |
|
I have tested this item ✅ successfully on 24304b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20544. |
|
I have tested this item ✅ successfully on 46119f0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20544. |
1 similar comment
|
I have tested this item ✅ successfully on 46119f0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20544. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20544. |
| @@ -161,7 +161,6 @@ | |||
| label="PLG_CODEMIRROR_FIELD_KEYMAP_LABEL" | |||
| description="PLG_CODEMIRROR_FIELD_KEYMAP_DESC" | |||
| default="" | |||
| filter="options" | |||
There was a problem hiding this comment.
The filter should remain here (it ensures that only the options listed can be saved, prevents potential DOM manipulation)
There was a problem hiding this comment.
This was mistaken for form rule. It should have been validate="options". Since filter="options" does nothing, I've removed it for now. Planning to add validation in separate PRs.
There was a problem hiding this comment.
Yeah, you're right. Getting my wires crossed again.
| @@ -175,7 +174,6 @@ | |||
| label="PLG_CODEMIRROR_FIELD_FULLSCREEN_LABEL" | |||
| description="PLG_CODEMIRROR_FIELD_FULLSCREEN_DESC" | |||
| default="F10" | |||
| filter="options" | |||
There was a problem hiding this comment.
The filter should remain here (it ensures that only the options listed can be saved, prevents potential DOM manipulation)
| @@ -196,7 +194,6 @@ | |||
| type="checkboxes" | |||
| label="PLG_CODEMIRROR_FIELD_FULLSCREEN_MOD_LABEL" | |||
| description="PLG_CODEMIRROR_FIELD_FULLSCREEN_MOD_DESC" | |||
| filter="options" | |||
There was a problem hiding this comment.
The filter should remain here (it ensures that only the options listed can be saved, prevents potential DOM manipulation)
Pull Request for Issue # .
Summary of Changes
Added/replaced filters (
optionsis not a valid filter, assume it was mistaken for validation rule).Synced fallback values.
Removed doubled empty value option from
appearancefield.Testing Instructions
Documentation Changes Required
No.