Update default plugin configs #20893

SharkyKZ · 2018-06-27T13:07:11Z

Pull Request for Issue # .

Summary of Changes

As per #20563, this syncs default plugin param values in installation SQL files with changes made in PRs #20544, #20456, #20422, #20412 and #20410. This mainly affects numeric values that were stored as strings.

Testing Instructions

Code review.

Documentation Changes Required

No.

Quy · 2018-06-27T17:58:23Z

installation/sql/mysql/joomla.sql

 (409, 0, 'plg_content_vote', 'plugin', 'vote', 'content', 0, 0, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 6, 0),
-(410, 0, 'plg_editors_codemirror', 'plugin', 'codemirror', 'editors', 0, 1, 1, 1, '', '{"lineNumbers":"1","lineWrapping":"1","matchTags":"1","matchBrackets":"1","marker-gutter":"1","autoCloseTags":"1","autoCloseBrackets":"1","autoFocus":"1","theme":"default","tabmode":"indent"}', '', '', 0, '0000-00-00 00:00:00', 1, 0),
+(410, 0, 'plg_editors_codemirror', 'plugin', 'codemirror', 'editors', 0, 1, 1, 1, '', '{"lineNumbers":1,"lineWrapping":1,"matchTags":1,"matchBrackets":1,"marker-gutter":1,"autoCloseTags":1,"autoCloseBrackets":1,"autoFocus":1,"theme":"default","tabmode":"indent"}', '', '', 0, '0000-00-00 00:00:00', 1, 0),


Default should be 0 to match in XML:
lineNumbers
lineWrapping
marker-gutter (should be markerGutter)

No settings:
autoFocus
tabmode

Existing SQL values should take priority over XML. Based on current values, all options should be enabled on new installations. I'll update #20544.

Quy · 2018-06-28T14:09:21Z

installation/sql/mysql/joomla.sql

-(418, 0, 'plg_search_contacts', 'plugin', 'contacts', 'search', 0, 1, 1, 0, '', '{"search_limit":"50","search_content":"1","search_archived":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
-(419, 0, 'plg_search_content', 'plugin', 'content', 'search', 0, 1, 1, 0, '', '{"search_limit":"50","search_content":"1","search_archived":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
-(420, 0, 'plg_search_newsfeeds', 'plugin', 'newsfeeds', 'search', 0, 1, 1, 0, '', '{"search_limit":"50","search_content":"1","search_archived":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
+(417, 0, 'plg_search_categories', 'plugin', 'categories', 'search', 0, 1, 1, 0, '', '{"search_limit":50,"search_content":1,"search_archived":1}', '', '', 0, '0000-00-00 00:00:00', 0, 0),


In XML files, search_content and search_archived are 0 except in plg_search_content

Updated values in plugins.

Quy · 2018-06-28T14:31:01Z

installation/sql/mysql/joomla.sql

 (432, 0, 'plg_user_joomla', 'plugin', 'joomla', 'user', 0, 1, 1, 0, '', '{"autoregister":"1","mail_to_user":"1","forceLogout":"1"}', '', '', 0, '0000-00-00 00:00:00', 2, 0),
-(433, 0, 'plg_user_profile', 'plugin', 'profile', 'user', 0, 0, 1, 0, '', '{"register-require_address1":"1","register-require_address2":"1","register-require_city":"1","register-require_region":"1","register-require_country":"1","register-require_postal_code":"1","register-require_phone":"1","register-require_website":"1","register-require_favoritebook":"1","register-require_aboutme":"1","register-require_tos":"1","register-require_dob":"1","profile-require_address1":"1","profile-require_address2":"1","profile-require_city":"1","profile-require_region":"1","profile-require_country":"1","profile-require_postal_code":"1","profile-require_phone":"1","profile-require_website":"1","profile-require_favoritebook":"1","profile-require_aboutme":"1","profile-require_tos":"1","profile-require_dob":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
+(433, 0, 'plg_user_profile', 'plugin', 'profile', 'user', 0, 0, 1, 0, '', '{"register-require_address1":1,"register-require_address2":1,"register-require_city":1,"register-require_region":1,"register-require_country":1,"register-require_postal_code":1,"register-require_phone":1,"register-require_website":1,"register-require_favoritebook":1,"register-require_aboutme":1,"register-require_tos":1,"register-require_dob":1,"profile-require_address1":1,"profile-require_address2":1,"profile-require_city":1,"profile-require_region":1,"profile-require_country":1,"profile-require_postal_code":1,"profile-require_phone":1,"profile-require_website":1,"profile-require_favoritebook":1,"profile-require_aboutme":1,"profile-require_tos":1,"profile-require_dob":1}', '', '', 0, '0000-00-00 00:00:00', 0, 0),


register-require_tos is 0 in XML

Quy · 2018-06-28T14:32:13Z

installation/sql/mysql/joomla.sql

@@ -613,7 +613,7 @@ INSERT INTO `#__extensions` (`extension_id`, `package_id`, `name`, `type`, `elem
 (448, 0, 'plg_twofactorauth_totp', 'plugin', 'totp', 'twofactorauth', 0, 0, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0),
 (449, 0, 'plg_authentication_cookie', 'plugin', 'cookie', 'authentication', 0, 1, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0),
 (450, 0, 'plg_twofactorauth_yubikey', 'plugin', 'yubikey', 'twofactorauth', 0, 0, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 0, 0),
-(451, 0, 'plg_search_tags', 'plugin', 'tags', 'search', 0, 1, 1, 0, '', '{"search_limit":"50","show_tagged_items":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
+(451, 0, 'plg_search_tags', 'plugin', 'tags', 'search', 0, 1, 1, 0, '', '{"search_limit":50,"show_tagged_items":1}', '', '', 0, '0000-00-00 00:00:00', 0, 0),


show_tagged_items is 0 in XML

Updated value in plugin.

Quy · 2018-06-28T18:07:09Z

plugins/user/profile/profile.php

@@ -273,7 +273,7 @@ public function onContentPrepareForm(JForm $form, $data)
 		}

 		$tosArticle = $this->params->get('register_tos_article');
-		$tosEnabled = $this->params->get('register-require_tos', 0);
+		$tosEnabled = ($this->params->get('register-require_tos', 0) == 2);


Remove outside () which are not necessary.

Quy · 2018-06-28T22:15:08Z

installation/sql/mysql/joomla.sql

 (409, 0, 'plg_content_vote', 'plugin', 'vote', 'content', 0, 0, 1, 0, '', '', '', '', 0, '0000-00-00 00:00:00', 6, 0),
-(410, 0, 'plg_editors_codemirror', 'plugin', 'codemirror', 'editors', 0, 1, 1, 1, '', '{"lineNumbers":"1","lineWrapping":"1","matchTags":"1","matchBrackets":"1","marker-gutter":"1","autoCloseTags":"1","autoCloseBrackets":"1","autoFocus":"1","theme":"default","tabmode":"indent"}', '', '', 0, '0000-00-00 00:00:00', 1, 0),
+(410, 0, 'plg_editors_codemirror', 'plugin', 'codemirror', 'editors', 0, 1, 1, 1, '', '{"lineNumbers":1,"lineWrapping":1,"matchTags":1,"matchBrackets":1,"markerGutter":1,"autoCloseTags":1,"autoCloseBrackets":1,"theme":"default"}', '', '', 0, '0000-00-00 00:00:00', 1, 0),


Please confirm if "theme":"default" should be empty. https://github.com/joomla/joomla-cms/pull/20544/files#diff-56697cf5f4f7b09581b782ea92afc869L226

Yes, it should be empty.

Quy · 2018-06-29T13:33:17Z

I have tested this item ✅ successfully on db777e4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.}

viocassel · 2019-01-13T13:37:39Z

I have tested this item ✅ successfully on db777e4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.}

Quy · 2019-01-13T15:29:31Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.}

richard67 · 2019-05-31T17:32:17Z

@SharkyKZ It seems meanwhile this PR got conflicts because changes in staging meanwhile. Do you think you can continue this PR or make a new one? Or is this PR obsolete now because things are right meanwhile in staging?

HLeithner · 2019-06-05T17:07:46Z

@SharkyKZ could you please resolve the conflicts?

SharkyKZ · 2019-06-05T18:00:04Z

Conflicts solved.

HLeithner · 2019-07-20T17:09:17Z

Do we have tests for all 3 database engines?

HLeithner · 2019-08-08T09:13:58Z

I removed RTC.

We need tests for mysql, pgsql and mssql please. Include the version in the testing comment.

Thanks for your effort testing this.

HLeithner · 2020-01-22T21:26:59Z

3rd database test pending....

zero-24 · 2021-08-08T21:10:37Z

Dear @SharkyKZ

in preperation of the upcomming release of Joomla 3.10 we have used GitHubs rename feature to rename the staging branch into 3.10-dev. Usually GitHub moves all existing PRs towards the new branch just fine, but here it didnt work. The reason seems to be that the fork of the CMS that was used as base for this PR has been deleted so GitHub does no longer have a base to rebase the PR against the new branch and we are also not able to reopen the PR. For that reason GitHub closed this PR in my name, when this issue is still valid It would require a new PR against the new 3.10-dev or 4.0-dev branch.

Update plugin configs

819765b

joomla-cms-bot added the PR-staging label Jun 27, 2018

Quy reviewed Jun 27, 2018

View reviewed changes

Update params

bd70c8d

Quy reviewed Jun 28, 2018

View reviewed changes

SharkyKZ added 3 commits June 28, 2018 20:47

plg_search_tags default values

18f2cac

Search plugin default values

5085152

plg_user_profile default values

5e9e744

Quy reviewed Jun 28, 2018

View reviewed changes

CS

4a9882a

Quy reviewed Jun 28, 2018

View reviewed changes

plg_editors_codemirror default value

db777e4

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2019

ghost added the J3 Issue label Apr 5, 2019

ghost removed the J3 Issue label Apr 19, 2019

Merge remote-tracking branch 'upstream/staging' into sqlPluginParams_1

7339ceb

Merge branch 'staging' into sqlPluginParams_1

d7a4d6e

HLeithner removed the RTC This Pull Request is Ready To Commit label Aug 8, 2019

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 8, 2019

Quy removed the RTC This Pull Request is Ready To Commit label Aug 8, 2019

Merge branch 'staging' into sqlPluginParams_1

7d583c8

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2020

Quy removed the RTC This Pull Request is Ready To Commit label Jan 26, 2020

Merge remote-tracking branch 'upstream/staging' into sqlPluginParams_1

4551e1d

zero-24 deleted the branch joomla:staging August 8, 2021 20:08

zero-24 closed this Aug 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default plugin configs #20893

Update default plugin configs #20893

SharkyKZ commented Jun 27, 2018

Quy Jun 27, 2018

SharkyKZ Jun 28, 2018

Quy Jun 28, 2018

SharkyKZ Jun 28, 2018

Quy Jun 28, 2018

Quy Jun 28, 2018

SharkyKZ Jun 28, 2018

Quy Jun 28, 2018

Quy Jun 28, 2018

SharkyKZ Jun 29, 2018

Quy commented Jun 29, 2018

viocassel commented Jan 13, 2019

Quy commented Jan 13, 2019

richard67 commented May 31, 2019

HLeithner commented Jun 5, 2019

SharkyKZ commented Jun 5, 2019

HLeithner commented Jul 20, 2019

HLeithner commented Aug 8, 2019

HLeithner commented Jan 22, 2020

zero-24 commented Aug 8, 2021

Update default plugin configs #20893

Update default plugin configs #20893

Conversation

SharkyKZ commented Jun 27, 2018

Summary of Changes

Testing Instructions

Documentation Changes Required

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Jun 29, 2018

viocassel commented Jan 13, 2019

Quy commented Jan 13, 2019

richard67 commented May 31, 2019

HLeithner commented Jun 5, 2019

SharkyKZ commented Jun 5, 2019

HLeithner commented Jul 20, 2019

HLeithner commented Aug 8, 2019

HLeithner commented Jan 22, 2020

zero-24 commented Aug 8, 2021