[4.0] Add Argon2id password handler to service chain and supported lookups #21167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone review the code here please. We should get this merged now and not leave it sitting here just because it is hard to test |
|
I have tested this item ✅ successfully on 765a633 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21167. |
|
Merged as JS failure is not related to this pr. thanks. |
It almost never is 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Similar to #20855 but for the 4.0 architecture, adds Argon2id password support to the API.
Testing Instructions
Code review unless you've actually got a PHP 7.3 alpha/nightly build with Argon2id support available