[4.0] Add default stages/transitions when creating a new workflow #21963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bembelimen
changed the title
ghost
mentioned this pull request
|
I have tested this item ✅ successfully on c2ad939 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21963. |
brianteeman
previously requested changes
Sep 2, 2018
| @@ -104,21 +105,64 @@ public function save($data) | |||
|
|
|||
| $result = parent::save($data); | |||
|
|
|||
| // Create a default stage | |||
| // Create a default stages/transitions | |||
There was a problem hiding this comment.
very minor but ==>
Create default stages/transitions
|
I have tested this item ✅ successfully on 2b68b26 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21963. |
|
@brianteeman can you please retest? |
|
Moving to RTC as the only change after Brians test was the inline comment changed. Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21963. |
|
I'm not convinced by default we should have an archived state in the default flow. but merging for now |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Sep 8, 2018
…omla#21963) * Make the new stage from a new workflow translateable * Create the default workflow stages/transitions when creating a new workflow * Typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21819 .
Summary of Changes
When creating a new workflow now all default stages (publish, unpublished, trashed, archived) and transitions (unpublish, publish, trash, archive) will be created (instead of only "published").
(And yes, transitions are not translated yet, will come after #21939)
Testing Instructions
Expected result
Actual result