[plg_content_loadmodule] Prevent issues with regular expression characters

[SharkyKZ]

Pull Request for Issue #21329.

Summary of Changes

This is an alternative to Rosie-Eagle#1 and #21948.

This fixes the issue of module positions and modules with titles containing special regular expression characters not being loaded.

Testing Instructions

Note, the use of } hasn't been fixed.

Copied from #21329 by franz-wohlkoenig:

1. Log in at the backend of joomla
2. Go to menu "Extensions > Modules".
3. Create a "Custom" module.
4. Give field 'title' the following value (without the quotes): "Some math: 1 + 1 = 2"
5. Save the module.
6. Next create a new article (or edit an existing one).
7. Make sure you can later view the article at the fronted of joomla, where visitors normally view the article.
8. Enter load module shortcode with your module type and title, e.g. {loadmodule mod_custom, Some math: 1 + 1 = 2}
9. Save the article.
10. View the article at the frontend of joomla.

Notice "{loadmodule mod_custom, Some math: 1 + 1 = 2}" not beeing replaced by the actual rendering of the module you created at steps 3 to 5. The text "{loadmodule mod_custom, Some math: 1 + 1 = 2}" is still there as if it were untouched.

Documentation Changes Required

No.

[ghost]

I have tested this item 🔴 unsuccessfully on 61ff38b

Module isn't rendered also by using this PR.

Note: Append a Module by click on "Module"-Button load it by ID, so this Problem didn't exist.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.}

[SharkyKZ]

There's an error in testing instructions. The shortcode should contain module name, not just title. So, for example, {loadmodule Some math: 1 + 1 = 2} should become {loadmodule mod_login,Some math: 1 + 1 = 2}.

[ghost]

I have tested this item ✅ successfully on a30e151

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.}

[HLeithner]

wouldn't it be easier to use preg_quote?

[SharkyKZ]

This was meant to be faster but now I'm wondering whether we need to use utf8 string functions from Joomla\String\StringHelper here.

[SharkyKZ]

No need to use utf8 functions. Works fine like this.

[jwaisner]

I have tested this item ✅ successfully on c6c07d6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.}

[jwaisner]

@franz-wohlkoenig Please test latest commit.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.}

[SharkyKZ]

RTC as previous test still good (latest commits include only branch updates).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.}

[HLeithner]

Thanks