-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module preview styling #22272
Module preview styling #22272
Conversation
Before this pr the module preview would display the position even if it is not active on the page. From your screenshot it looks like you had to create a module in order for it to show. ?? This is much more readable but personally I miss the outline of the position |
Nothing has really changed except the styling. Previously when the module was not published, the module position was also echoed as module content. It was not visible because it was covered by the module details (position and style). I can add back in the outline. My reasoning for removing the outline was that the module width should be evident by the width of the details block. The height equally evident by the following module position. |
I have found the module outline is useful when the template hardcodes something. For example some templates hardcode the search but keep a module nearby |
Just saw your new screenshot. Is the styling your own or the default styling for that position? |
I have removed the content = position if the module is not published. Kittens die when I start diving to deep in to php so might be a good idea if someone could double check that commit. |
Thanks - looks much better without the module name visible |
That styling would be separate to the module styling. Similar to the previous outline. |
That would be great then - thank you |
Module outline added as seen in previous screenshot |
I have tested this item ✅ successfully on 6efa100 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272. |
1 similar comment
I have tested this item ✅ successfully on 6efa100 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22272. |
Pull Request for Issue # .
Summary of Changes
General styling. Most notable difference is moving positioning from absolute to relative.
Testing Instructions
Open frontend with module position preview... https://docs.joomla.org/Finding_module_positions_on_any_given_page
Before
After
Documentation Changes Required