New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] RFC Quickicons Joomla and Extensions updates #23095
[4.0] RFC Quickicons Joomla and Extensions updates #23095
Conversation
|
||
// Quickicon specific | ||
.message-alert { | ||
text-align: left !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely there is a way to do this without using !important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what is used in node_modules and vendor:
@each $breakpoint in map-keys($grid-breakpoints) {
@include media-breakpoint-up($breakpoint) {
$infix: breakpoint-infix($breakpoint, $grid-breakpoints);
.text#{$infix}-left { text-align: left !important; }
.text#{$infix}-right { text-align: right !important; }
.text#{$infix}-center { text-align: center !important; }
}
}
and ported to /administrator/templates/atum/css/bootstrap.css
once npm ci has run:
.text-left {
text-align: left !important; }
.text-right {
text-align: right !important; }
.text-center {
text-align: center !important; }
administrator/language/en-GB/en-GB.plg_quickicon_joomlaupdate.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/en-GB.plg_quickicon_extensionupdate.ini
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
punctuation as commented inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve language strings
34d6646
to
605bfc5
Compare
I have tested this item ✅ successfully on a419403 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
Note: furher PR will correct RTL for the J version |
@richard67 |
a419403
to
a330779
Compare
@richard67 |
@infograf768 I don't see any difference in the Persian screenshots. What has changed? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
formerly (see on top), the version read alpha6-dev etc. |
I see now. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
@infograf768 Now I tested and it seemed ok. But after switching back the Joomla update channel to "Default" and changing back Version.php and fixing the database, I get a javascript error from the Joomla update check, and the update check does not finish: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
@infograf768 I've started again with clean 4.0-dev, installed patch tester, applied your patch, run "npm ci", switched on system debugging in global settings so uncompressed js is used. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
@infograf768 It seems that the "if (updateInfoList.length === 0) {" you've removed with your last change was not there for no reason. |
on ipad now. will look later. the issue was to get the ‘success’ class instead of only ‘pulse’. we may have to define as var and empty the ‘updateinfo.version’ first. |
@infograf768 Can you check if my PR infograf768#50 against your branch is the right thing to correct it and get what you want with the success class? Unfortunately I made a mistake in title of the commit so it contains "warning" instead of "success", which is misleading. So you better just check it and if ok do the same change yourself. |
@infograf768 I've just tested my changes from infograf768#50, applied to this PR here, and it works. Javascript error is gone, and Joomla Update is green. |
Thanks @richard67 |
Yes, I've just tested again, works all well. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
} | ||
|
||
// Message specific | ||
joomla-alert .joomla-alert--close, joomla-alert .joomla-alert-button--close { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerts are not part of the template. please put RTL CSS in the custom element file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@C-Lodder
This is an override for RTL.
The scss for alert is in /node_modules/joomla-ui-custom-elements/src/scss/alert/alert.scss
There is no provisions done for RTL in custom-elements which means we would have to use html[dir=rtl]
(which is not a problem I guess).
Also it means that until someone merges a possible pull request in https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.css and possibly https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.min.css, this PR would not correct by itself the RTL display issue with alerts.
EDIT: Maybe it is only in https://github.com/joomla-projects/custom-elements/blob/master/src/scss/alert/alert.scss
The other solution I see is to add these (with html[dir=rtl]
), in the atum/scss/blocks/_alert.scss
and also in Cassiopea equivalent file —which means that every 3rd party template will necessarily have to do that to be rtl compatible.
Just let me know what is the way to go.
calling @wilsonge as he has the hand on merging stuff in https://github.com/joomla-projects/custom-elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@C-Lodder
ping 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with @wilsonge will make PR towards https://github.com/joomla-projects/custom-elements/blob/master/src/scss/alert/alert.scss
and delete the same in template-rtl.scss>
We will have to wait the PR is merged and compile is done to see the rtl results here.
573f0ac
to
0b2d04f
Compare
RTL can now be tested fully as alert has been updated. |
I have tested this item ✅ successfully on 4ed7a1b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095. |
@wilsonge |
Thanks JM! |
and @richard67 ;) |
Replaces and complete #23061 (for what concerns Joomla Update).
Implement NOTE in #23061 (comment)
Summary of Changes
warning
when an update is available asdanger
is used in case of error.Update Now
andView Updates
buttons to the bottom right of the Message, centering the rest of the message.joomla-alert
,
and:
in the language stringsText::script
tofalse
by default to let single quotes in language strings to display unescaped instead of\'
Testing Instructions
To test on 4.0-dev branch
Concerning joomlaupdate:
Modify version.php line 63 to const EXTRA_VERSION = 'alpha4-dev';
Go to database and Fix database.
Then in JoomlaUpdate Options choose Custom URL and add this link (Thanks Tobias) :
https://update.joomla.org/core/nightlies/next_major_list.xml
Save Options.
Display Control Panel.
Concerning extensions update:
Install an older language pack in order to get a warning for an update.
fr-FR_joomla_lang_full_3.9.0v1.zip
in both cases, test also RTL by installing and switching to Persian language.
Test before patch, then run npm ci
Expected result
@tuum @wilsonge