New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX 3.9.1] Add column alias com_finder Search Filter (Published state broken) #23194
Conversation
I have tested this item ✅ successfully on a12ba33 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23194. |
1 similar comment
I have tested this item ✅ successfully on a12ba33 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23194. |
Honestly I'm wondering if we do not have here BC break. As unpublishing is also not working anymore in DPCalendar. Should we not fix the cause instead? |
maybe #22851 have side-effect |
That's the pr which broke it. |
Yes, #22851 is a B/C break if you consider that it changed a previously working behavior. This was my first thought, and in my extension too i had this issue. We can fix B/C here by adding a Maybe the way would be to define a standard for "published" as a column name when using Joomla api for status control (we already have standard The problem today is Joomla core using mainly |
Now, to give my personal opinion: i used |
I think best (if purpose to fix a B/C break) would be an The problem is Joomla core using 3 naming (published, state, enabled) for the same functionnality. |
But then we have to fix this in joomla 4 and not in a patch release as it is a BC break. |
No, this should still be tested and included in core regardless of #23197. The fact that these aliases have not been included into the core components is a bug in their own right.
We really should not require explicit column names. That is exactly what this aliasing logic is supposed to take care of. In the context of com_contact, "state" refers to what most people consider a "province" and not an alias of "published" so you can't place a hard reservation on the "state" column name without creating problems for any extension with a table storing addressing data. |
I don't fix column naming here (this should be for Joomla 4) but missing column aliases for a proper use of Joomla api "publish" item. Open an issue RFC for Joomla 4: #23198 |
So... even |
It can be documented that We don't force |
👍 |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23194. |
Pull Request for Issue with com_finder Smart Search Filters published state broken in 3.9.1
Related to PR #22851
Summary of Changes
Testing Instructions
Expected result
Actual result