-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Count to Tags Overview #23562
Add Count to Tags Overview #23562
Conversation
@@ -248,8 +251,11 @@ | |||
</td> | |||
<?php endif; ?> | |||
|
|||
|
|||
|
|||
<td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you want this column to be hidden on a phone also?
->select('COUNT(' . $db->quoteName('tag_map.content_item_id') . ')') | ||
->from($db->quoteName('#__contentitem_tag_map', 'tag_map')) | ||
->where($db->quoteName('tag_map.tag_id') . '= ' . $db->quoteName('a.id')); | ||
$query->select('(' . $subQueryCountTaggedItems->__toString() . ') AS countTaggedItems '); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$query->select('(' . $subQueryCountTaggedItems->__toString() . ') AS countTaggedItems '); | |
$query->select('(' . $subQueryCountTaggedItems->__toString() . ') AS countTaggedItems'); |
I have tested this item ✅ successfully on 2f9988f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23562. |
I have tested this item ✅ successfully on 2f9988f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23562. |
@franz-wohlkoenig @Quy this has 2 successful tests. Shouldn't it be RTC? On the other hand since its a new feature it needs to be rebased for 4.0 |
@fabpacheco There are requested changes to be done. |
@pe7er sorry no new features for 3.9.x series please rebase on 4.0 |
@HLeithner Thanks, I understand. |
Thank you all for testing + your comments @Quy @chmst @kofaysi @viocassel @viocassel @fabpacheco @HLeithner |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23562 |
Pull Request to improve the information about the used Tags in the website by adding a new Tagged Items column. The Tagged Items column shows a counter of the amount of items that use that tag. It's sortable so you can easily get an overview about the most or less used tags.
Summary of Changes
In the Back-end under Components > Tags you'll see an overview of all created Tags.
Testing Instructions
Expected result
A new column "Tagged Items" is available. You can click on the "Tagged Items" header to order the column. You can select the order also via the "Sort Table By:" dropdown on the top right.