[4.0][NO CACHE] Refactor the build tools pt.2 #23786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all dev dependencies
…ools-refactoring * '4.0-dev' of github.com:joomla/joomla-cms: [4.0] Correcting icons display in debug bar (#23732)
…ools-refactoring * '4.0-dev' of github.com:joomla/joomla-cms: modified_time check (#23689) [4.0] FIX SQL int default value to numeric (#23669) Clean up hard coded usage of state values (#23330) [4.0] - fix save article (#23638) [4.0] JS error when closing a item and going back to a list view (#23642) Fixes plugins ordering (#23731) [4.0] [a11y] Make ActionButton Featured accessible (#23718) Remove extra type attribute (#23753) [4.0] Remove unused string (#23750) Fix stats alert information (#23727) [4.0] Remove deprecated functions isSite and isAdmin (#22492)
|
@Hackwar so no files moved to media... |
dgrammatiko
changed the title
dgrammatiko
changed the title
…omla-cms into 4.o-dev-tools-refactoring-templates * '4.0-dev-tools-refactoring' of github.com:dgrammatiko/joomla-cms: re-re-trigger retrigger drone
…ools-refactoring-templates * '4.0-dev' of github.com:joomla/joomla-cms: [4.0][NO CACHE] Refactor the build tools (#23723) # Conflicts: # .eslintignore # administrator/templates/atum/scss/font-awesome.scss # administrator/templates/atum/src/scss/template.scss # build.js # build/build-modules-js/compilecss.es6.js # build/build-modules-js/compilejs.es6.js # build/build-modules-js/error-pages.es6.js # build/build-modules-js/init.es6.js # build/build-modules-js/javascript/compile-es6.es6.js # build/build-modules-js/javascript/compile-w-c.es6.js # build/build-modules-js/javascript/handle-file.es6.js # build/build-modules-js/stylesheets/scss-transform.es6.js # build/build-modules-js/watch.es6.js # templates/cassiopeia/src/scss/template.scss
|
@wilsone more pain here, sorry 😐. I promise this is the last one, after this one any changes will be only on the build tools script, no more files moving around... |
…ools-refactoring-templates * '4.0-dev' of github.com:joomla/joomla-cms: (153 commits) [4.0] Fix debug (#23637) Fix typehint to be compatible with parent interface (#24041) [4.0]Table text changed (#24022) [4.0] Change Status dropdown consistency (#24078) Fix Finder logging table creation in MySQL (#24060) [4.0] Remove com_admin profile (#24064) [4.0] Fix webcomponents not being included on the page (#24075) Fix path to file (#24074) Fix codestyle in mod search, move calendar locale to new location Fix stability Global checkin - select call style (#24031) [4.0] An error has occurred on Search Filter (#23679) [4.0] Group toolbar buttons for workflow stages and transitions (#23608) com_finder update (#24047) [4.0] Toolbar button consistency (#24048) Fix default date for postgresql (#24046) [4.0] Update bootstrap version (#24003) [4.0][com_media] RTL: adapting media manager to rtl + some (#24043) [4.0] Smart Search: Adding nested taxonomy (#21327) [4.0] Update composer deps (#24037) ...
|
@wilsonge let me know if you want to merge this otherwise I'll just close it |
|
OK I want it - but i'd like to keep the scss folder top level please. Also we need to gitignore the template css and js files (especially the minified version if/when we go this way) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The second part of the refactoring of the npm build tools.
Templates get an
srcassets_sourcefolder which can have subfolders forcss,jsorscssScss files compiled (unmagnified and minified as well) and stored in the usual
template/cssCSS files get copied over to the usual
template/cssfolder and minified as wellJS files can be any of the 3 versions already introduced in the previous PR (.es6.js, .es5.js and .w-c.es6.js) The respective product of these will be placed in
template/jsWatch gets the second round of revamp also it gets more specific.
Without any param will watch the
build/media_sourcefolderCan also accept
administrator/templatesso someone can work on a backend templateor
templatesand this will watch the front end templatesATM it will not handle plain css files (that will be on the next PR)
Also there is no logic to synchronise the removal of a source file to be correctly reflected in the distribution folders (again that's for the next PR)
Testing Instructions
npm initnode run build.js --watchedit the file
joomla-cms/build/media_source/plg_installer_webinstaller/scss/client.scsscheck if the css and .min.css in the media forder was updatedCreate a file
joomla-cms/build/media_source/plg_installer_webinstaller/scss/test.scsswith any valid code (eg body {display:none;} ) check if the css and .min.css in the media forder was createdpress ctrl+c to quit the watch.
Repeat the procedure but this time use
node run build.js --watch administrator/templatesand edit create a file in the atum/src/scss folderHappy coding 🍸
Expected result
Actual result
Documentation Changes Required
Based on the #23723