Add layouts to plg_user_terms #23787
Conversation
layouts/plugins/user/terms/label.php
Outdated
|
|
||
| $attribs = array(); | ||
| $attribs['class'] = 'modal'; | ||
| $attribs['rel'] = '{handler: \'iframe\', size: {x:800, y:500}}'; |
There was a problem hiding this comment.
Can you please move this to use Bootstrap Modal instead of the Mootools?
There was a problem hiding this comment.
no, my aim is to do one change a time. The aim of this PR is to add layout overrides for this plugin, just as I did for the plg_system_privacyconsent, not to change the logic.
There was a problem hiding this comment.
It's 2019, we shouldn't use Mootools.-
There was a problem hiding this comment.
what is the code change needed for switching from mootools to bootstrap modal?
There was a problem hiding this comment.
See #22926 for an example.
Converting from MooTools to Bootstrap is a change for another PR. Please do not include it here.
There was a problem hiding this comment.
Thanks @mbabker and agree
|
I have tested this item ✅ successfully on c56805f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
Thanks for testing @tecpromotion :) Appreciate it! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
I have tested this item ✅ successfully on 13a7114 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
Thanks for testing @viocassel |
|
@Quy I see two successful tests, only one is counted? Do you know why and what is needed for this to go RTC? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
When a new commit is made after a test, you need to retest it. The old tests don't count anymore. |
|
@Bakual which is strange, because the one counted as successful is the one before the last change? anyway @viocassel and @tecpromotion just to make sure, can you both (re) test #please :) |
|
It shows the one from Vio as successful one. The first one from Stefan is discarded since you did two commits afterwards. |
|
I have tested this item ✅ successfully on 7ff2f05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
I have tested this item ✅ successfully on 7ff2f05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787. |
|
thx |
Pull Request for Issue # n/a.
Summary of Changes
the layouts for plg_user_terms (label and termsnote) are hardcoded into the field and cannot be overwritten by a template override
This PR adds layouts for both the label and for the termsnote (message). these layouts can be overwritten via template overrides.
Testing Instructions
on the front-end user registration page the terms box should show
Apply this PR
[test] on the front-end user regsitration page the terms box should be exactly the same as without this PR.
-> tab Create Overrides
-> column Layouts
-> select plugins > user
Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/message.php
4. change the class from alert-info to alert-warning
[Result 1] refresh on the front-end the new user registration form
Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/label.php
5. change
<span class="star"> *</span></label>to<span class="star">©*</span></label>[Result 2] refresh on the front-end the new user registration form
New result
Actual result
Make sure that after applying the PR everything works as before.
Documentation Changes Required