case insensitive management for email address

[alikon]

Pull Request for Issue #24095 .

Summary of Changes

use lower() to check user email

Testing Instructions

see #24095

Expected result

test@test.fr and Test@test.fr must be detected as the same email address even on db's like Postgresql

Actual result

detected as the different email address even on db's like Postgresql

Note

mysql < 5.7 don't support function based index ... iirc

[mdaoudi123]

Thanks a lot for your help.

But There is also another file where exists a email comparaison:

• components/com_users/models/reset.php => function processResetConfirm
• components/com_users/models/remind.php => function processRemindRequest
• ...
  and into other files..... (search for "$db->quoteName('email')")

Could you please add the correction to thoses files @alikon

[mdaoudi123]

Can i download the new patch some where?
@alikon
Thanks

[alikon]

you can test with https://docs.joomla.org/Component_Patchtester_for_Testers

[mdaoudi123]

Hello,
Thanks for the patchTester,
I tested the patch and it's OK.
Could you merge this branch and build a new patch?

[alikon]

@mdaoudi123 please mark as tested on https://issues.joomla.org/tracker/joomla-cms/24117
this should be carefully tested on mysql side too....and mssql also i'm afraid

[mdaoudi123]

Hello,
im going to test it into POSTGRES too,
can you tell me how to mark this post as tested?
Thanks

[alikon]

see https://docs.joomla.org/Testing_Joomla!_patches

[alikon]

thanks @richard67

[richard67]

Drone failure is not related to this PR, is javascript stuff. PHPCS is ok now.

[richard67]

@mdaoudi123 Sorry for the inconvenience and the long waiting time. Could you test this PR again with its latest changes?

[richard67]

@alikon Could you synch this PR with staging by using that button in GitHub at the bottom of your PR?

[brianteeman]

Unless there are conflicts there is no benefit

[richard67]

Yes but looks less scary for beginner testers.

[richard67]

I have tested this item ✅ successfully on a8c025b

Tested on MySQL and PostgreSQL.

On MySQL it does not break anything.

On PostgreSQL it checks now for present email address in case-insensitive way without touching existing user data.

Tested as follows:

Pre-conditions: In Global configuration, set error reporting to maximum or development and watch the PHP error logs during the tests. Check that there are no errors reported.

1. Without this PR applied, have super admin email address be like e.g. "test@test.local".
2. Create another user with email address be like e.g. "Test@test.local", i.e. same as 1st one but different case.
   Result: User is created.
3. Apply this PR.
4. Go to "Extensions -> Manage -> Database" and fix the database error to apply the schema update sql of this PR.
   Result: Database upt to date.
5. Create another user with email address be like e.g. "tEst@test.local", i.e. same as 1st and 2nd one but different case.
   Result: User is not created because email address already exists.
6. Edit the 2nd user but do not change email address and try to save.
   Result: User can't be saved because email address already exists.
7. Exit user edit without saving.
8. Work a bit in backend with user-related functions like privacy requests or other stuff related to files changed by this PR.
   Result: You can't add new users or change users so more than one user has same email address, case-independent, but the existing 2 users with same case-independent email addresses do not make problems.

@alikon Could you update your testing instructions to what I wrote here above so other users can test more easily?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24117.}

[richard67]

@alikon why closing this?

[richard67]

@alikon Did you maybe accidently hit the wrong button, close instead of rebase?

[richard67]

I have tested this item ✅ successfully on 27d3519

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24117.}

[richard67]

@mdaoudi123 Sorry for the inconvenience.

Could you test this PR again with its latest changes?

And then mark your test result at the issue tracker here https://issues.joomla.org/tracker/joomla-cms/24117, using the "Test this" button at the top left corner? Then just select the appropriate result and submitt.

[jwaisner]

I have tested this item ✅ successfully on 27d3519

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24117.}

[SharkyKZ]

RTC.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24117.}

[mdaoudi123]

Thank's a lot.

[mdaoudi123]

@alikon This correction will be available into the new joomla release?.

regards

[alikon]

it's up to the maintainers/release lead to decide if and when

[HLeithner]

Can you please rename the sql file to 3.9.15 then I will merge this.

[alikon]

renamed

[HLeithner]

I'm not the biggest fan this PR but think it solves more problems then it creates.

Thanks