[com_fields] - fix show on side/admin/both #24397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Mar 28, 2019
|
I have tested this item ✅ successfully on 322f2c2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24397. |
|
@boomsya please test. |
|
Thx, I tested it my self. |
|
Actually, this has broken field display. I think the "Show on" setting should only affect where the field should be visible in the edit view - in admin, in front end or both. However, now the field is not displayed any more in the article view if the "Show on" setting is set to "Administrator", regardless of the "Automatic display" setting under "Render options". |
AndySDH
added a commit
to AndySDH/joomla-cms
that referenced
this pull request
May 30, 2019
The PR was adding a check to display the custom field on the frontend based on a parameter that was meant to be a check for the edit form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23246 .
Summary of Changes
Checked if the field should be showed on the form
Testing Instructions
create edit an article custom field
set show on to adminstrator only
Expected result
the field is not showed on from site
Actual result
the field is showed on from site despite settings