New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Separate activation from resetToken #24461
base: 5.2-dev
Are you sure you want to change the base?
Conversation
Hides the header and options in full screen mode to prevent overlap over the editor area in full-screen mode. Another possible alternative is displaying both the options as well as the editor in full-screen mode but purely a user preference. Because the need for save and other options is not as important in full-screen mode.
I have tested this item ✅ successfully on 3f1645c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461. |
I have tested this item ✅ successfully on 3f1645c |
I doubt the change in the template is intentional ;) also, seems like a very convoluted way to determine if the resettoken is > 3 days? wouldn't |
I have tested this item ✅ successfully on 3f1645c This PR already has two tests on the same commit ... but the system is counting only one.... I'm retesting it and making it count... it has 3 tests now. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461. |
@Arpit-24 can you solve conflict please |
This pull requests has been automatically converted to the PSR-12 coding standard. |
This pull request has been automatically rebased to 5.1-dev. |
I have tested this item ✅ successfully on f101243 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461. |
Pull Request for Issue #24269 .
Summary of Changes
Added new column of resetToken to users table.
Reset token expires after 3 days
The issue originally for 3.9 also existed in 4.0
Testing Instructions
Please refer to the original issue for details.