Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Separate activation from resetToken #24461

Open
wants to merge 42 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

Arpit-24
Copy link
Contributor

@Arpit-24 Arpit-24 commented Apr 2, 2019

Pull Request for Issue #24269 .

Summary of Changes

Added new column of resetToken to users table.
Reset token expires after 3 days
The issue originally for 3.9 also existed in 4.0

Testing Instructions

Please refer to the original issue for details.

Arpit-24 and others added 15 commits March 24, 2019 02:41
Hides the header and options in full screen mode to prevent overlap over the editor area in full-screen mode.

Another possible alternative is displaying both the options as well as the editor in full-screen mode but purely a user preference. Because the need for save and other options is not as important in full-screen mode.
@Kaustubharas
Copy link

I have tested this item ✅ successfully on 3f1645c

Tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

@ahghatol
Copy link

I have tested this item ✅ successfully on 3f1645c

@euismod2336
Copy link
Contributor

I doubt the change in the template is intentional ;) also, seems like a very convoluted way to determine if the resettoken is > 3 days? wouldn't now - date > (24 * 3600) * 3 be simpler to check? Do I also read it correct that now if you have an activationToken, you can never complete the reset process?

@Quy Quy added Conflicting Files Updates Requested Indicates that this pull request needs an update from the author and should not be tested. labels Nov 11, 2019
@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 3f1645c

From #JMAD19 PBF

This PR already has two tests on the same commit ... but the system is counting only one....

I'm retesting it and making it count... it has 3 tests now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

@alikon
Copy link
Contributor

alikon commented Nov 15, 2019

@Arpit-24 can you solve conflict please

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@rdeutz rdeutz changed the base branch from 4.2-dev to 5.0-dev October 21, 2022 08:30
@rdeutz rdeutz changed the title [4.0] Separate activation from resetToken [5.0] Separate activation from resetToken Oct 21, 2022
@rdeutz rdeutz added Maintainers Checked Used if the PR is conceptional useful and removed PR-4.2-dev labels Oct 21, 2022
@bembelimen bembelimen added this to the Joomla! 5.0 milestone Oct 23, 2022
@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:52
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@emedinainnotec
Copy link

I have tested this item ✅ successfully on f101243

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

@Quy Quy added PR-5.1-dev and removed PR-5.0-dev labels Oct 7, 2023
@Quy Quy removed this from the Joomla! 5.0.0 milestone Oct 7, 2023
@rdeutz rdeutz self-assigned this Oct 24, 2023
@bembelimen bembelimen changed the base branch from 5.1-dev to 5.2-dev March 2, 2024 19:32
@Quy Quy removed the PR-5.1-dev label Mar 2, 2024
@HLeithner HLeithner changed the title [5.0] Separate activation from resetToken [5.2] Separate activation from resetToken Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators Maintainers Checked Used if the PR is conceptional useful PR-5.2-dev Ready to take over This is an abandoned feature which can be taken over by another person to finish it. Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet