[4.0] Fix tags creation #24743
[4.0] Fix tags creation #24743
Conversation
joomla-cms-bot
added
NPM Resource Changed
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -105,7 +105,7 @@ window.customElements.define('joomla-field-fancy-select', class extends HTMLElem | |||
| // Handle typing of custom term | |||
| if (this.allowCustom) { | |||
| this.addEventListener('keydown', (event) => { | |||
| if (event.keyCode !== this.keyCode.ENTER || event.target !== this.choicesInstance.input) { | |||
| if (event.keyCode !== this.keyCode.ENTER || event.target !== this.choicesInstance.input.element) { | |||
There was a problem hiding this comment.
Line 108 exceeds the maximum line length of 100 max-len
|
I have tested this item ✅ successfully on 9ea050f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743. |
|
I have tested this item ✅ successfully on 9ea050f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743. |
ghost
removed
NPM Resource Changed
|
Status "Ready To Commit". |
it did because i tested downgrading the version and it worked ;) |
|
@franz-wohlkoenig it definitely doesn't fix the first issue and i can't reproduce the second (although as hannes suggested on the second it was related to setup doesn't mean it's fixed) |
joomla-cms-bot
added
NPM Resource Changed
| @@ -105,7 +105,8 @@ window.customElements.define('joomla-field-fancy-select', class extends HTMLElem | |||
| // Handle typing of custom term | |||
| if (this.allowCustom) { | |||
| this.addEventListener('keydown', (event) => { | |||
| if (event.keyCode !== this.keyCode.ENTER || event.target !== this.choicesInstance.input) { | |||
| if (event.keyCode !== this.keyCode.ENTER | |||
| || event.target !== this.choicesInstance.input.element) { | |||
ghost
removed
NPM Resource Changed
|
Status set on Pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24743. |
wilsonge
force-pushed
the
bug/tags-field
branch
from
76d56a7
to
db6e5e4
Compare
ghost
added
NPM Resource Changed
|
@franz-wohlkoenig just a codestyle fix for hound. No need to retest. As soon as tests pass i'm going to merge |
|
Thanks guys! |
Summary of Changes
Currently the creation of dynamic tags is broken in the 4.0 branch. This fixes it (has been the case since we merged the update of choices 7)
Testing Instructions
Type a tag with a new value into the tags box and hit enter
Expected result
Tag is created
Actual result
It isn't
Documentation Changes Required
none