Fix not converted boolean in route::_ and log warning

[HLeithner]

Pull Request for Issue #25204 .

Summary of Changes

Added boolean conversion removed in pr #24089, also log a warning if wrong parameter type is used. Should be removed with J4.

Testing Instructions

use jroute::_ with $tls parameter as int and boolean (true/false)

Expected result

Now we convert it if type is Boolean.

Actual result

Boolean didn't got converted to 0 or 1.

[richard67]

@HLeithner It seems you mixed up texts for "Expected result" and "Actual result" in your description. "Expected result" should describe result with this PR applied, "Actual result" should describe result of current staging, i.e. without this PR applied.

[SharkyKZ]

This is unnecessary, IMO. Strings and even arrays worked here too until recently. But argument has been documented as integer since at least 1.5.

[HLeithner]

@SharkyKZ you are right it's unnecessary anyway I changed it to convert all variables to int.

[SharkyKZ]

Just noticed this is in Route::_(). But it should be in Route::link().

[HLeithner]

For me it's only a pre Joomla 3.9 thing (and should be removed in j4) because Route::link added in this version but I'm still not sure to add it as you already stated the documentation says it's an integer.

[SharkyKZ]

I have tested this item ✅ successfully on 955c92a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.}

[richard67]

@kirblam Please test this at it handles your issue #25204 .

[ghost]

@kirblam how to: https://docs.joomla.org/Testing_Joomla!_patches

[Quy]

I have tested this item ✅ successfully on 955c92a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25225.}