New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact and Newsfeed title not incremented during batch copy #25259
Conversation
I have tested this item ✅ successfully on 13bc80c With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259. |
I have not tested this item. [Tue Jun 18 20:54:06.411713 2019] [php7:notice] [pid 6007] [client 192.168.98.1:60754] PHP Notice: Undefined property: ContactTableContact::$title in /home/richard/lamp/public_html/joomla-cms/libraries/src/MVC/Model/AdminModel.php on line 1534, referer: https://www.joomla.vmnet2.local/administrator/index.php?option=com_contact This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259. |
I have tested this item ✅ successfully on 13bc80c PR works as described. With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds. In addition, it makes the This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259. |
@Quy Just when you had finished typing I had noticed that, too 😄 |
I have tested this item ✅ successfully on 13bc80c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259. |
proud of you guys, not so common behaviour to admit a momentary lapse of fault |
For me it is normal behavior. |
Thanks! |
Pull Request for Issue #25255.
Summary of Changes
Set title column alias in
ContactTable
andNewsfeedTable
table.Use column aliases in
Joomla\CMS\MVC\Model\AdminModel::generateTitle()
andJoomla\CMS\MVC\Model\AdminModel::generateNewTitle()
.Testing Instructions
Go to contacts or newsfeeds list in backend.
Select a contact/newsfeed.
Click Batch button.
Perform batch copy to the same category.
Expected result
Contact/newsfeed title incremented, e.g.
Sample Contact
becomesSample Contact (2)
.Actual result
Contact/newsfeed title not incremented.
Documentation Changes Required
No.