Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact and Newsfeed title not incremented during batch copy #25259

Merged
merged 4 commits into from Jun 23, 2019

Conversation

Projects
None yet
6 participants
@SharkyKZ
Copy link
Contributor

commented Jun 18, 2019

Pull Request for Issue #25255.

Summary of Changes

Set title column alias in ContactTable and NewsfeedTable table.
Use column aliases in Joomla\CMS\MVC\Model\AdminModel::generateTitle() and Joomla\CMS\MVC\Model\AdminModel::generateNewTitle().

Testing Instructions

Go to contacts or newsfeeds list in backend.
Select a contact/newsfeed.
Click Batch button.
Perform batch copy to the same category.

Expected result

Contact/newsfeed title incremented, e.g. Sample Contact becomes Sample Contact (2).

Actual result

Contact/newsfeed title not incremented.

Documentation Changes Required

No.

@SharkyKZ SharkyKZ changed the title Contact title not incremented during batch copy Contact and Newsfeed title not incremented during batch copy Jun 18, 2019

SharkyKZ added some commits Jun 18, 2019

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I have tested this item successfully on 13bc80c

Works as described.

With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I have not tested this item.

Hmm, I get:

[Tue Jun 18 20:54:06.411713 2019] [php7:notice] [pid 6007] [client 192.168.98.1:60754] PHP Notice: Undefined property: ContactTableContact::$title in /home/richard/lamp/public_html/joomla-cms/libraries/src/MVC/Model/AdminModel.php on line 1534, referer: https://www.joomla.vmnet2.local/administrator/index.php?option=com_contact
[Tue Jun 18 20:54:44.544675 2019] [php7:notice] [pid 6019] [client 192.168.98.1:60758] PHP Notice: Undefined property: NewsfeedsTableNewsfeed::$title in /home/richard/lamp/public_html/joomla-cms/libraries/src/MVC/Model/AdminModel.php on line 1534, referer: https://www.joomla.vmnet2.local/administrator/index.php?option=com_newsfeeds


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I have tested this item successfully on 13bc80c

Me idiot. PHP notice undefined property was BEFORE the PR was applied 😄

PR works as described.

With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds.

In addition, it makes the PHP Notice: Undefined property: ContactTableContact::$title and PHP Notice: Undefined property: NewsfeedsTableNewsfeed::$title not happen anymore when batch copying contacts or newsfeeds.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@Quy Just when you had finished typing I had noticed that, too 😄

@Quy

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I have tested this item successfully on 13bc80c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.

@Quy

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.

@joomla-cms-bot joomla-cms-bot added the RTC label Jun 18, 2019

@alikon

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

proud of you guys, not so common behaviour to admit a momentary lapse of fault

@richard67

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

For me it is normal behavior.

@wilsonge wilsonge merged commit eb3c321 into joomla:staging Jun 23, 2019

5 checks passed

Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC label Jun 23, 2019

@wilsonge wilsonge added this to the Joomla 3.9.9 milestone Jun 23, 2019

@SharkyKZ SharkyKZ deleted the SharkyKZ:j3/contactBatch branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.