Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Contact/Field Editors-XTD buttons when using search #25478

Merged
merged 1 commit into from Jul 20, 2019
Merged

Fix Contact/Field Editors-XTD buttons when using search #25478

merged 1 commit into from Jul 20, 2019

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jul 8, 2019

Pull Request for Issue # .

Summary of Changes

Fixes inserting Contact/Field after using search in Editors-XTD modal.
Removes loose </a> tag.

Testing Instructions

Edit an article.
In editor click Contact or Field button.
In the modal, use the search form.
Click to insert Contact, Field or Field Group.

Expected result

Contact/Field/Field Group inserted.

Actual result

Contact/Field/Field Group not inserted.

Documentation Changes Required

No.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6ab7a39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25478.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6ab7a39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25478.

@Quy Quy removed the PR-staging label Jul 8, 2019
@Quy
Copy link
Contributor

Quy commented Jul 8, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25478.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 8, 2019
@ghost ghost added the PR-staging label Jul 9, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner merged commit b3431c5 into joomla:staging Jul 20, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 20, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Jul 20, 2019
@SharkyKZ SharkyKZ deleted the j3/editorsXtdSearch branch July 20, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants