-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] [plg_system_actionlogs] Convert to prepared statement #25503
Merged
wilsonge
merged 10 commits into
joomla:4.0-dev
from
HLeithner:prepared-plg-system-actionlogs
Nov 1, 2019
Merged
[4.0] [plg_system_actionlogs] Convert to prepared statement #25503
wilsonge
merged 10 commits into
joomla:4.0-dev
from
HLeithner:prepared-plg-system-actionlogs
Nov 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jul 11, 2019
Quy
reviewed
Jul 11, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Quy
reviewed
Jul 12, 2019
SharkyKZ
reviewed
Jul 19, 2019
SharkyKZ
reviewed
Sep 18, 2019
Quy
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Sep 18, 2019
…into prepared-plg-system-actionlogs
I have tested this item ✅ successfully on 4472095 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503. |
Quy
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Oct 19, 2019
I have tested this item ✅ successfully on f2b26e5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated SQL queries to prepared statements and made some cleanups around the queries.
Testing Instructions
Use the plugin in all ways you can think of.
Use the privacy component and trigger action log entries.
Expected result
Nothing changed.