Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [plg_system_actionlogs] Convert to prepared statement #25503

Merged
merged 10 commits into from
Nov 1, 2019

Conversation

HLeithner
Copy link
Member

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Use the plugin in all ways you can think of.

Use the privacy component and trigger action log entries.

Expected result

Nothing changed.

Co-Authored-By: Quy <quy@fluxbb.org>
@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Sep 18, 2019
@waader
Copy link
Contributor

waader commented Oct 19, 2019

I have tested this item ✅ successfully on 4472095

Tested with postgresql.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503.

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 19, 2019
@Quy
Copy link
Contributor

Quy commented Oct 30, 2019

I have tested this item ✅ successfully on f2b26e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503.

@Quy
Copy link
Contributor

Quy commented Oct 30, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25503.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 30, 2019
@wilsonge wilsonge merged commit 0fa8282 into joomla:4.0-dev Nov 1, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2019
@Quy Quy added this to the Joomla 4.0 milestone Nov 6, 2019
@HLeithner HLeithner deleted the prepared-plg-system-actionlogs branch March 29, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants