Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Sample data fix - Tags ids need to be sent as a string to the helper #25773

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Aug 3, 2019

Tags need to be submitted as a string to the model rather than as an integer. So simply mapping them to a string here. To test install sample data. Before patch there are integers in the main homepage article tags. After patch they are the expected colours from Joomla 3.

@wilsonge wilsonge changed the title Tags ids need to be sent as a string to the helper [4.0] Sample data fix - Tags ids need to be sent as a string to the helper Aug 3, 2019
@alikon
Copy link
Contributor

alikon commented Aug 4, 2019

I have tested this item ✅ successfully on 18d654a

tested on postgresql 11.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25773.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 18d654a

Tested with MySQL 5.7 and PostgreSQL 10.9.

@wilsonge I gave it a good test because it works, but I would prefer if you would also apply my suggested change for using array_slice($tagIds, 0, 3) instead of array($tagIds[0], $tagIds[1], $tagIds[2]).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25773.

@ghost ghost removed the PR-4.0-dev label Aug 4, 2019
@ghost
Copy link

ghost commented Aug 4, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 4, 2019
@ghost ghost added the PR-4.0-dev label Aug 4, 2019
Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>
@wilsonge wilsonge merged commit cf7629d into joomla:4.0-dev Aug 4, 2019
@wilsonge
Copy link
Contributor Author

wilsonge commented Aug 4, 2019

Thanks guys!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 4, 2019
@wilsonge wilsonge deleted the fix/testing-data-tags branch August 4, 2019 10:33
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 4, 2019
@richard67
Copy link
Member

Thanks George!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants