Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make restore.php PHP 7.4 compatible #25801

Merged
merged 5 commits into from Oct 28, 2019

Conversation

@alikon
Copy link
Contributor

alikon commented Aug 9, 2019

Pull Request for Issue #25800 .

Summary of Changes

just extracted the work already done by @SharkyKZ in #25782 as a separate file as requested #25800 (comment)

Testing Instructions

update joomla

Expected result

update should work with any issue or/notice warning for 7.4

Actual result

deprecation on php 7.4

To Do

change the copyright information

richard67 and others added 2 commits Aug 9, 2019
Add note about modification to the header
@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Aug 9, 2019

The title says this PR is to make restore.php compatible with php7.4. Which implies that without this PR restore.php will not work with 7.4

Am I missing something here. I thought deprecated in 7.4 meant it will now generate a deprecation warning - which is not the same as not working.

PS 7.4 is not scheduled for release until Nov 28 iirc

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Aug 9, 2019

A deprecation warning means more or less that the code should not longer be used and should be changed and depending of your error reporting this could lead to an upgrade joomla upgrade error if the json response adds deprecation notices.

That's the reason I choose the title in the original issue. As developer you should take deprecation warnings as serious as fatal errors because sooner or later they lead to a fatal error.

There is no reason to wait till php 7.4 is released to patching this syntax. The 7.4 will not be in 3.9.11 and 3.9.12 comes in September so people have 2-3 month before php 7.4 is released and can update to have a nice working cms even on php 7.4.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Aug 9, 2019

As developer you should take deprecation warnings as serious as fatal errors because sooner or later they lead to a fatal error.

I guess that's not the policy here for our own code then as J3 has been using deprecaated code for a very very long time :)

@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Aug 9, 2019

I guess that's not the policy here for our own code then as J3 has been using deprecaated code for a very very long time :)

We should mitigate this if possible... at least j4 should make it better at this front....

Copy link
Contributor

richard67 left a comment

I can't test without having a PHP 7.4, but code review is good.

@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Aug 20, 2019
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.12 milestone Aug 20, 2019
@zero-24 zero-24 added the RTC label Aug 20, 2019
@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Aug 20, 2019
@HLeithner HLeithner merged commit f34d093 into joomla:staging Oct 28, 2019
4 checks passed
4 checks passed
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Oct 28, 2019
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Oct 28, 2019

Thanks for PHP 7.4 fix.

@alikon alikon deleted the alikon:patch-111 branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.