Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict search result messages by putting it in parentheses #26065

Merged
merged 3 commits into from Sep 28, 2019

Conversation

@ma-at
Copy link
Contributor

ma-at commented Aug 29, 2019

Pull Request for Issue # .

The or in the were clause will give a result for all users.

Summary of Changes

By putting it in parenthesis it will restrict to the user only.

Testing Instructions

If you search messages with a keyword I suppose you only search in your own messages. By the or in the were clause you also get results from other users.

Expected result

The search should give you only results from your own messages.

Actual result

results from all messages.

Documentation Changes Required

@ma-at

This comment has been minimized.

Copy link
Contributor Author

ma-at commented Aug 29, 2019

This is my first pull request so not sure if I did it well

@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Aug 29, 2019

Hi @ma-at
to be a little bit more helpfull 😄
just fulfill the missing template points like :

  • Testing Instructions
  • Expected result
  • Actual result

it's a little bit hard to guess what you are trying to achieve.... or me i'm too naive

@ma-at

This comment has been minimized.

Copy link
Contributor Author

ma-at commented Aug 29, 2019

@alikon

This comment has been minimized.

Copy link
Contributor

alikon commented Aug 29, 2019

thanks for the explanation,much more clear, now let's wait from some other's feedback , i'm not one of heavy user of that feature/use case

@SharkyKZ

This comment has been minimized.

Copy link
Contributor

SharkyKZ commented Sep 18, 2019

I have tested this item successfully on bf8e7ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

1 similar comment
@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Sep 18, 2019

I have tested this item successfully on bf8e7ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

@Quy

This comment has been minimized.

Copy link
Contributor

Quy commented Sep 18, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26065.

@joomla-cms-bot joomla-cms-bot added the RTC label Sep 18, 2019
@HLeithner HLeithner merged commit 163234b into joomla:staging Sep 28, 2019
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/drone/pr Build is failing
Details
Hound No violations found. Woof!
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

HLeithner commented Sep 28, 2019

Thanks for catching this bug.

@joomla-cms-bot joomla-cms-bot removed the RTC label Sep 28, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.13 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.