New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Improve article list performance on multilingual sites #26465
Conversation
I have tested this item ✅ successfully on 10687ec About performance I can't say anything because my test data set is too small. But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log. There is a PHP notice "Undefined index: link in /layouts/joomla/content/associations.php on line 18" at least when using PostgreSQL before and after having applied this PR, so not related to this PR. This just as info for other testers. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465. |
Sometimes content languages are not added after language install. I've helped myself then with uninstalling languages and installing again. |
seems that German - DE allows me to run sample multilanguage data (just for note on postgresql now) |
I'm using German (DE), French and for RTC sometimes Persian. |
@alikon you may have to create a Content Language manually. |
I have tested this item ✅ successfully on 89e6b32 About performance I can't say anything because my test data set is too small. But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465. |
@SharkyKZ ok maybe another issue to open if it will be still there when we will have languages pack ready for 4, anyway PR seems fine & all works as before , despite i don't have a good big dataset to do some real case performance check... i cannot trust my EXPLAIN with my short data , but it looks fine and i cannot guess how it can works worst than now... |
I have tested this item ✅ successfully on 89e6b32 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465. |
Thanks! |
Pull Request for Issue #25770.
Summary of Changes
Replaces
JOIN
andGROUP
clauses in query with a subquery.Testing Instructions
Set up a multilingual site.
Enable associations.
Create some articles and add associations.
View article list in backend.
Expected result
Works like before.
Documentation Changes Required
No.