Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration menu to login module #26582

Closed

Conversation

Giuse69
Copy link
Contributor

@Giuse69 Giuse69 commented Oct 13, 2019

This PR adds an option to login module to set a menu item for registration page.
Useful to override default registration link "index.php?option=com_users&view=registration" to a custom page

Summary of Changes

New option in login module

Testing Instructions

Apply the PR.

  1. Go to front end: nothing should be changed in registration link in login module.
  2. Edit login module and set a menu item: go to front-end and registration link should point to the deisderd menu item.

Expected result

See above.

Actual result

Documentation Changes Required

Add option in login module to set a menu item for registration page. Useful to override default registration link "index.php?option=com_users&view=registration" to a custom page
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Oct 13, 2019
@richard67
Copy link
Member

@HLeithner Is this a new feature which should go into 4.0-dev, or is it ok for staging? Just asking.

@HLeithner
Copy link
Member

@Giuse69 thanks for you contribution but as richard already stated it's a new feature and have to go into Joomla 4.0. please rebase your PR against 4.0-dev

I'm closing this pr for staging.

@HLeithner HLeithner closed this Oct 13, 2019
@Giuse69 Giuse69 deleted the Login-module-with-registration-link branch October 13, 2019 21:46
@Giuse69
Copy link
Contributor Author

Giuse69 commented Oct 14, 2019

Done this PR for Joomla 4.0 #26589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants