Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Make meta description and meta keywords have defaults #26714

Merged
merged 3 commits into from
Oct 19, 2019

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Oct 19, 2019

Summary of Changes

Makes metakey and metadesc have default values of empty string in the table. Also means these fields aren't required for the API (so I've amended that test to reflect)

Testing Instructions

Disable the Publishing tabset from being displayed in component options. Try and save an article. Before patch you get a warning metakey is required. After patch article saves successfully.

Documentation Changes Required

None

- Fixes joomla#26650
- Makes fields optional when creating articles in the API
@wilsonge wilsonge changed the title Make meta description and meta keywords have defaults [4.0] Make meta description and meta keywords have defaults Oct 19, 2019
@uglyeoin
Copy link
Contributor

I have tested this item ✅ successfully on 28659b4

I have tested this successfully. Before there was an error on patch there was none.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714.

@richard67
Copy link
Member

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 28659b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714.

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@wilsonge wilsonge merged commit beac6a0 into joomla:4.0-dev Oct 19, 2019
@wilsonge
Copy link
Contributor Author

Thanks guys!

@joomla-cms-bot joomla-cms-bot removed RTC This Pull Request is Ready To Commit labels Oct 19, 2019
@wilsonge wilsonge deleted the fix_26650 branch October 19, 2019 21:24
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants