Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Heading is missing on "Template Preview" Popup #26720

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

wilsonge
Copy link
Contributor

Pull Request for Issue #26691 .

Summary of Changes

Uses new style syntax for the template preview button which correctly sets the title in the the popup modal

Testing Instructions

Open the template preview modal. Before the patch there is a missing title (see image in the original issue). After patch the title now shows and the close button is correctly spaced

Documentation Changes Required

None

@uglyeoin
Copy link
Contributor

I have tested this item ✅ successfully on 074c694

I see the header. Probably an extra point for accessibility. Although I did hear popups cannot be accessible because of screen readers or something. I'm no expert.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

I have tested this item ✅ successfully on 074c694


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@richard67
Copy link
Member

I have tested this item ✅ successfully on 074c694


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.

@wilsonge wilsonge merged commit afb0634 into joomla:4.0-dev Oct 19, 2019
@wilsonge
Copy link
Contributor Author

Thanks guys!

@wilsonge wilsonge deleted the bugfix/missing-preview-title branch October 19, 2019 21:05
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants