Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update News Feed ID in Single News Feed menu item - MySQL #27100

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@imanickam
Copy link
Contributor

imanickam commented Nov 19, 2019

Pull Request for Issue # .
No Issue Registered

Summary of Changes

At present the News Feed ID mentioned/chosen in the SQL of the menu item with title Single News Feed is 4. Whereas there are only three News Feed Items defined in the Sample Data Learn and their IDs are 1, 2, and 3. So, there is no News Feed item with ID 4. This results in error when the menu item Single News Feed is chosen in the front end when the Sample Data Learn is installed.

Testing Instructions

(a) Install Joomla! with Sample Data LEARN. Choose this option while installing Joomla!

(b) View the site

(c) On the site, in the menu "About Joomla!", click on the menu item "Single News Feed"
1_Single_News_Feed_Menu_Item

Expected result

5_Result_of_Single_News_Feed_Menu_Item_After_Correction

Actual result

2_Error_Feed_Not_Found

Documentation Changes Required

There are only three News Feed Items Defined in the Sample Data (Learn) and their IDs are 1, 2, and 3. See the following image.
4_News_Feeds_Available_in_Sample_Learn

Where as in the insert statement of SQL for the menu item "Single News Feed", the ID is mentioned as 4. This results in the error. See the image below:
3_Menu_Item_Single_News_Feed

If the ID is changed to an ID of a News Feed item that is present (example: 2), the error will not show and the correct news feed would be shown.
6_Menu_Item_Single_News_Feed_After_Correction

Note:
The testing cannot be done with Patch Tester. First testing must be done just by installing Joomla! The second test also must done as a fresh install. However, after unzipping the files, the modified file/files has/have to be copied from Github. This action will overwrite the appropriate sample data files. After that, the installation dialog has to be invoked.

At present the News Feed ID mentioned/chosen in the SQL of the menu item with title Single News Feed is 4.  Whereas there are only three News Feed Items defined in the Sample Data Learn and their IDs are 1, 2, and 3.  So, there is no News Feed item with ID 4.  This results in error when the menu item Single News Feed is chosen in the front end when the Sample Data Learn is installed.
@imanickam imanickam changed the title Update News Need ID in Single News Feed menu item Update News Need ID in Single News Feed menu item - MySQL Nov 19, 2019
@imanickam imanickam changed the title Update News Need ID in Single News Feed menu item - MySQL Update News Feed ID in Single News Feed menu item - MySQL Nov 19, 2019
@SharkyKZ

This comment has been minimized.

Copy link
Contributor

SharkyKZ commented Nov 21, 2019

I have tested this item successfully on 8e6406a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27100.

1 similar comment
@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Nov 21, 2019

I have tested this item successfully on 8e6406a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27100.

@infograf768 infograf768 removed the PR-staging label Nov 21, 2019
@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Nov 21, 2019

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27100.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 21, 2019
@infograf768 infograf768 merged commit 80edab8 into joomla:staging Nov 26, 2019
4 checks passed
4 checks passed
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joomla-cms-bot joomla-cms-bot removed the RTC label Nov 26, 2019
@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Nov 26, 2019

tks

@zero-24 zero-24 added this to the Joomla! 3.9.14 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.