Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update News Feed ID in Single News Feed menu item - SQL Azure #27102

Merged
merged 1 commit into from Nov 24, 2019
Merged

Update News Feed ID in Single News Feed menu item - SQL Azure #27102

merged 1 commit into from Nov 24, 2019

Conversation

imanickam
Copy link
Contributor

@imanickam imanickam commented Nov 19, 2019

At present the News Feed ID mentioned/chosen in the SQL of the menu item with title Single News Feed is 4. Whereas there are only three News Feed Items defined in the Sample Data Learn and their IDs are 1, 2, and 3. So, there is no News Feed item with ID 4. This results in error when the menu item Single News Feed is chosen in the front end when the Sample Data Learn is installed.

Please review the instructions in the Pull Request #27100 - The testing has to be done in the SQL Azure database.

At present the News Feed ID mentioned/chosen in the SQL of the menu item with title Single News Feed is 4.  Whereas there are only three News Feed Items defined in the Sample Data Learn and their IDs are 1, 2, and 3.  So, there is no News Feed item with ID 4.  This results in error when the menu item Single News Feed is chosen in the front end when the Sample Data Learn is installed.
@imanickam imanickam changed the title Update News Need ID in Single News Feed menu item - SQL Azure Update News Feed ID in Single News Feed menu item - SQL Azure Nov 19, 2019
@alikon
Copy link
Contributor

@alikon alikon commented Nov 21, 2019

I have tested this item successfully on 03a830c

code review
same change as #27100 #27101


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27102.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 21, 2019

I have tested this item successfully on 03a830c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27102.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 21, 2019

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27102.

@joomla-cms-bot joomla-cms-bot added the RTC label Nov 21, 2019
@rdeutz rdeutz merged commit a830f0a into joomla:staging Nov 24, 2019
5 checks passed
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC labels Nov 24, 2019
@Quy Quy added this to the Joomla! 3.9.14 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants