Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix batchSelector is undefined #27390

Merged
merged 2 commits into from Jan 2, 2020
Merged

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Dec 31, 2019

Pull Request for Issue #27149 .

Summary of Changes

Fix batchSelector is undefined.

Testing Instructions

Go to Global Configuration > System.
Enable Debug System.
Create a new custom field.
View fields list.
Enable browser's web developer.
View console for error.

Apply PR.
Run npm i.

Actual result

TypeError: batchSelector is undefined batch-language.js:43:7

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Dec 31, 2019
@richard67
Copy link
Member

@Quy I can't reproduce the issue with the instructions above. What am I missing?

@Quy
Copy link
Contributor Author

Quy commented Dec 31, 2019

So you are unable to reproduce it before applying the PR? Here is a screenshot.

27390

@richard67
Copy link
Member

So you are unable to reproduce it before applying the PR?

@Quy Yes, was testing with Article fields, too, and did not have the type error.

@richard67
Copy link
Member

@Quy Now I did exactly the same as you, i.e. I gave the field the title "Text". Now I can reproduce. Strange.

@richard67
Copy link
Member

I have tested this item ✅ successfully on aa3adec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

@richard67
Copy link
Member

Any idea why api tests fail in drone? Looks like the usual randomly occurring timeout to me, but I'm not sure.

@alikon
Copy link
Contributor

alikon commented Jan 1, 2020

I have tested this item ✅ successfully on aa3adec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 1, 2020
@alikon
Copy link
Contributor

alikon commented Jan 1, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 1, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 1, 2020
@HLeithner HLeithner merged commit 6842a9e into joomla:4.0-dev Jan 2, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 2, 2020
@Quy Quy deleted the 27149-batchSelector branch January 2, 2020 11:41
Quy pushed a commit to Quy/joomla-cms that referenced this pull request Jan 6, 2020
Quy pushed a commit that referenced this pull request Jan 6, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Feb 3, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants