Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tooltip from pagebreak #27436

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jan 8, 2020

Pull Request for Issue #27400 .

Summary of Changes

This PR removes Tooltips from pagebreak prev and next buttons. It continues the improvment made in #27398.

Testing Instructions

Make an article with one or more pagebreaks and inspect the behaviour and sourcecode before and after patch.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 7e8588f

checked source code via FTP


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27436.

@jwaisner
Copy link
Member

jwaisner commented Jan 8, 2020

I have tested this item ✅ successfully on 7e8588f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27436.

@Quy Quy removed the PR-staging label Jan 8, 2020
@Quy
Copy link
Contributor

Quy commented Jan 8, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27436.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 8, 2020
@HLeithner HLeithner merged commit 2145256 into joomla:staging Jan 8, 2020
@HLeithner
Copy link
Member

I think that's a ok compromise.

Thanks

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jan 8, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.15 milestone Jan 8, 2020
@chmst chmst deleted the pagebreak-remove-tooltip branch January 9, 2020 00:03
@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jan 9, 2020

Not that it matters anymore but reasoning for this is nonsense. If your site relies on some asset NOT being loaded, you're doing something terribly wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants