[4.0] Center modal on mobile

[brianteeman]

Pull Request for Issue #27536 .

Summary of Changes

Bizarrely bootstrap does not center modals on devices smaller than 567px eg mobile phones

Testing Instructions

Go to the admin dashboard
Reduce viewport width down to a mobile size
Click the "Add module to the dashboard" button at the bottom of the page

Expected result

Horizontally aligned modal

Actual result

Modal aligned to the left

apply the pr run npm i or node build.js --compile-css

[richard67]

I have tested this item ✅ successfully on 71b426d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.}

[Quy]

I have tested this item ✅ successfully on 71b426d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.}

[richard67]

Thanks.

[brianteeman]

thanks

[chmst]

I don't agree with this change. I think changes should never be made in the vendor directory but in the overrides.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.}

[brianteeman]

@chmst as far as I understand that is the folder for vendor overrides

[richard67]

@chmst as far as I understand that is the folder for vendor overrides

Was my understanding, too, but I might be wrong.

[Quy]

@chmst I think you are right. It should have been modified here:
\administrator\templates\atum\scss\blocks\_modals.scss

[richard67]

@chmst I think you are right. It should have been modified here:
\administrator\templates\atum\scss\blocks\_modals.scss

@brianteeman Could you check and if necessary make a new PR?

[brianteeman]

This PR was correct

[chmst]

Your changes are correct.
But the code would be easier maintain if you could do them in scss/blocks/_modals where all the overrides for modals are.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27859.}

[brianteeman]

That's the problem with us having two different places where code is being overridden. It would be easier to maintain if there was only one place and not two.

[infograf768]

It is indeed very confusing where to modify/change stuff for this template.
The question is: are you willing to make a PR to move the code to \administrator\templates\atum\scss\blocks\_modals.scss or not.
If you are not willing to, no problem, I will do.

[brianteeman]

If the code is moved then all the code in that vendor folder should be moved as well and the imports removed

[brianteeman]

and/or it should be clearly documented when to use the vendor folder

[infograf768]

Well, this case is quite clear:
atum vendor modal only deals with jviewport stuff

blocks/modal deals with all specific modal classes. btn, header, body, title, etc.
Therefore .modal-dialog should also be there.

[brianteeman]

clear as mud. the logic behind the decision escapes me

[infograf768]

The whole way Atum scss are made is indeed clear as mud. The use of svg is a p i t a (see #27864 )
Nevertheless and until someone modifies all of that, let's be consequent with what we have.
Will make PR.

[brianteeman]

i dont see how you come to the conclusion that it is in the wrong place

[infograf768]

I give up.

[N6REJ]

@brianteeman putting modal overrides in modals ( \administrator\templates\atum\scss\blocks\_modals.scss )
makes perfect sense to me. I get that it's confusing but it can be fixed one bite at a time. Lets at least get the ball rolling by putting your pr there.
I hope that makes sense to you.

[brianteeman]

Just for clarity - it is not an override