New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] fix error of styling issue with save and close button #27816
Conversation
@Subhang23 Our Pull Request (PR) template provides 2 pre-defined section, "Expected result" and "Actual result". "Expected result" shall describe what is the right, expected behavior which is approached with the PR, i.e. the result after having applied the PR. "Actual result" shall describe the current, actual behavior of Joomla (3 or 4, depending on which version the PR is made for, in case of this PR: 4). Now you used "Present result" and "Actual result" in this PR. Due to a certain ambiguity of the English language for that word, "Present" can be a verb and mean "to show something to someone", but it also can be an adjective and mean (almost) same as "current" or "actual". So for a quick reader it is not really clear which of your screenshots shows the situation before and which one shows the sitation after applying your PR. Of course one could test to find it out, but for readers it would be better if it would be more clear. Could you correct the section headings above your screenshots so that it is like I described above, "Actual result" for what we have in Joomla 4 now, and "Expected result" for how it with your PR aplied? Thanks in advance. |
The intended design is for all those buttons to be 100% width on a mobile |
@richard67 I have changed it and am sorry for the improper message. |
@brianteeman Would this be good? |
yes that is the intended design |
Looks good but has to be tested in RTL and with other pages. |
I should note that I dont understand why these two dropdown buttons are coded differently #27767 |
@brianteeman @richard67 @infograf768 Is this fine? |
No need to say sorry. I've explained how we normally do it, you followed that, so all is fine. |
@Quy Is this good? |
Almost there.
to
before this modification, we get after this modification, we get |
I have tested this item ✅ successfully on 50c28d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816. |
@Quy |
I have tested this item ✅ successfully on 50c28d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27816. |
tks |
Please test #27841 solving all alignments |
Pull Request for Issue #26771
Summary of Changes
Fixed styling issue with Save & Close button on mobile on article page
Testing Instructions
Expected result
The content in "Save and Close" button should be aligned properly.
Actual result
Documentation Changes Required