[4.0]fix error of twice clicking on toolbar and its disappearance on resizing #27958

Subhang23 · 2020-02-17T06:01:55Z

Pull Request for Issue #26543 and #27957 .

Summary of Changes

Added class to the div so that on loading it stays in either collapsed form or not-collapsed form(previously it was in a state of mix).
Added querySelectors to ensure that whenever screen size is that of desktop the classes of toolbar stays the same.

Testing Instructions

Go to any page which has a toolbar and reduce the width of the screen to a mobile size.

Expected result

You can open or close the toolbar with a single click and on resizing and closing the toolbar and again resizing the toolbar is intact.

Actual result

With the initial state as pulled up only one click is required. Even on removing toolbar in mobile-view and resizing the toolbar is seen

Documentation Changes Required

Subhang23 · 2020-02-17T06:12:10Z

SharkyKZ · 2020-02-17T06:14:45Z

Now the toolbar is missing on large screens.

Subhang23 · 2020-02-17T06:19:58Z

I understood the error it was because if the toolbar is compacted in mobile-view it is hidden in desktop-view. This might also be the reason for Issue #27957 .

infograf768 · 2020-02-17T07:59:23Z

Looks like working.
Now the toolbar is showing on desktop
Note: If the screen is reduced, the toolbar closed and then the screen enlarged to desktop, it requires a reload to get the toolbar again.
Issue or not?

SharkyKZ · 2020-02-17T08:00:27Z

That's the issue reported in #27957.

Subhang23 · 2020-02-17T08:20:54Z

That's the issue reported in #27957.

I am currently working on it.

Subhang23 · 2020-02-17T08:21:16Z

Looks like working.
Now the toolbar is showing on desktop
Note: If the screen is reduced, the toolbar closed and then the screen enlarged to desktop, it requires a reload to get the toolbar again.
Issue or not?

Is this fine?

infograf768 · 2020-02-17T08:27:17Z

Is this fine?

When #27957 is solved, yes.

Subhang23 · 2020-02-17T08:42:24Z

So should I close this PR and open a PR that solves this issue and Issue #27957 together. I thought they can be solved separately, so I thought of opening 2 separate PR's.
What should I do @infograf768 ?

infograf768 · 2020-02-17T08:44:50Z

I am not the one to decide.
If you can solve it together here or in a new PR, it is easier on testers.

Subhang23 · 2020-02-17T11:10:37Z

@infograf768 I have fixed both the issues with this PR. Please review it.

brianteeman · 2020-02-17T14:03:03Z

Looks good to me

infograf768 · 2020-02-18T06:29:02Z

I have tested this item ✅ successfully on a02351f

Great!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27958.}

build/media_source/templates/atum/js/template.es6.js

Subhang23 · 2020-02-18T13:41:57Z

@C-Lodder I have made the required changes.

administrator/templates/atum/index.php

C-Lodder · 2020-02-19T10:25:14Z

So right now, every time you change the viewport size by 1px, you're going to be searching to DOM 5 times. Not very good for performance.

C-Lodder · 2020-02-19T11:00:18Z

@Subhang23 targetting DOM elements should go outside of the resize event listener.

administrator/templates/atum/index.php

Subhang23 · 2020-04-03T13:37:27Z

@wilsonge please review it

wilsonge · 2020-04-04T16:47:58Z

build/media_source/templates/atum/js/template.es6.js

    window.addEventListener('resize', () => {
+      if (window.innerWidth >= 576) {
+        if (toolbar && !toolbar.querySelector('#subhead').classList.contains('show')) {


In cpanel #subhead doesn't exist and this causes a JS error getting the property classList of null

wilsonge · 2020-04-04T16:50:23Z

This doesn't work for me. First of all it totally fails on cpanel (see comment above).

When the menu is open and i leave mobile menu it stays open. However when the mobile menu is hidden it doesn't reappear at all. See screenshot - there's no way to reopen the menu at all

alikon · 2020-04-04T17:03:34Z

same from my test

Subhang23 · 2020-04-04T20:28:54Z

I am not sure if this is the right place to ask but I have run into a problem while setting up Joomla on my local server

I am running it on Ubuntu 19.04 php7.3

wilsonge · 2020-04-08T15:07:31Z

not sure what's going on there :( looks very sad. are you sure Joomla is even loading and it's not something from the web server. all our messages should have more info than that

particthistle · 2020-06-28T06:19:51Z

I have tested this item 🔴 unsuccessfully on 32c00cb

Patch was unable to be applied. Receiving:

Error
The patch could not be applied because the repository is missing

@Subhang23 if you're still having issues with your local installation, read https://magazine.joomla.org/all-issues/june-2020/github-installing-git which might reveal something you've done wrong with your local installation, though this article outlines XAMPP not Ubuntu specifically.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27958.}

Quy · 2020-07-17T21:40:13Z

Please test PR #30131

fix error of twice clicking on toolbar

850aef7

joomla-cms-bot added the PR-4.0-dev label Feb 17, 2020

Subhang23 mentioned this pull request Feb 17, 2020

[4.0] Mobile toolbar button requires double touch to close #26543

Closed

reappearance of toolbar by setting default state to collapsed

ee21a8f

Subhang23 changed the title ~~fix error of twice clicking on toolbar~~ [4.0]fix error of twice clicking on toolbar Feb 17, 2020

disappearing toolbar on resizing

883a59d

joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Feb 17, 2020

Subhang23 mentioned this pull request Feb 17, 2020

[4.0]Toolbar disappearing on reducing and increasing size of screen #27957

Closed

Subhang23 changed the title ~~[4.0]fix error of twice clicking on toolbar~~ [4.0]fix error of twice clicking on toolbar and its disappearance on resizing Feb 17, 2020

fix issue of screen size in between desktop and mobile

a02351f

C-Lodder reviewed Feb 18, 2020

View reviewed changes

build/media_source/templates/atum/js/template.es6.js Outdated Show resolved Hide resolved

C-Lodder reviewed Feb 18, 2020

View reviewed changes

build/media_source/templates/atum/js/template.es6.js Outdated Show resolved Hide resolved

C-Lodder reviewed Feb 18, 2020

View reviewed changes

build/media_source/templates/atum/js/template.es6.js Outdated Show resolved Hide resolved

C-Lodder reviewed Feb 18, 2020

View reviewed changes

build/media_source/templates/atum/js/template.es6.js Outdated Show resolved Hide resolved

changing query selectors

9d0e085

infograf768 reviewed Feb 19, 2020

View reviewed changes

administrator/templates/atum/index.php Outdated Show resolved Hide resolved

changed name of id

9cedeba

improve performance

369f3a4

changed position of query selector

42dac1d

brianteeman mentioned this pull request Mar 11, 2020

[4] Atum. Buttons behavior on resize. #28288

Closed

wilsonge reviewed Apr 1, 2020

View reviewed changes

administrator/templates/atum/index.php Show resolved Hide resolved

fixed permissions

32c00cb

wilsonge reviewed Apr 4, 2020

View reviewed changes

Quy added Updates Requested Indicates that this pull request needs an update from the author and should not be tested. Ready to take over This is an abandoned feature which can be taken over by another person to finish it. labels May 25, 2020

Quy mentioned this pull request Jun 7, 2020

[4.0b1] plugin manager toolbar on mobile state not correct button? #29468

Closed

ReLater mentioned this pull request Jun 8, 2020

[4.0b1] Button toggle on mobile view starts on wrong state #29488

Closed

Quy mentioned this pull request Jul 17, 2020

[4.0] Fix toolbar collapse in mobile view #30131

Merged

Quy closed this Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0]fix error of twice clicking on toolbar and its disappearance on resizing #27958

[4.0]fix error of twice clicking on toolbar and its disappearance on resizing #27958

Subhang23 commented Feb 17, 2020 •

edited

Subhang23 commented Feb 17, 2020

SharkyKZ commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

SharkyKZ commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

brianteeman commented Feb 17, 2020

infograf768 commented Feb 18, 2020

Subhang23 commented Feb 18, 2020

C-Lodder commented Feb 19, 2020

C-Lodder commented Feb 19, 2020

Subhang23 commented Apr 3, 2020

wilsonge Apr 4, 2020

wilsonge commented Apr 4, 2020

alikon commented Apr 4, 2020

Subhang23 commented Apr 4, 2020

wilsonge commented Apr 8, 2020

particthistle commented Jun 28, 2020

Quy commented Jul 17, 2020

[4.0]fix error of twice clicking on toolbar and its disappearance on resizing #27958

[4.0]fix error of twice clicking on toolbar and its disappearance on resizing #27958

Conversation

Subhang23 commented Feb 17, 2020 • edited

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Subhang23 commented Feb 17, 2020

SharkyKZ commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

SharkyKZ commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

infograf768 commented Feb 17, 2020

Subhang23 commented Feb 17, 2020

brianteeman commented Feb 17, 2020

infograf768 commented Feb 18, 2020

Subhang23 commented Feb 18, 2020

C-Lodder commented Feb 19, 2020

C-Lodder commented Feb 19, 2020

Subhang23 commented Apr 3, 2020

wilsonge Apr 4, 2020

Choose a reason for hiding this comment

wilsonge commented Apr 4, 2020

alikon commented Apr 4, 2020

Subhang23 commented Apr 4, 2020

wilsonge commented Apr 8, 2020

particthistle commented Jun 28, 2020

Quy commented Jul 17, 2020

Subhang23 commented Feb 17, 2020 •

edited