Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Delete version number in manifest #27969

Merged
merged 5 commits into from Feb 17, 2020

Conversation

astridx
Copy link
Contributor

@astridx astridx commented Feb 17, 2020

New trial of #25820

Summary of Changes

I deleted the version number from the XML manifest files. This number has no task at the moment.

I think that the supported version for an extension should be checked in the install script by the installation and I think that unnecessary program code is not good for a software. In my opinion, it unsettles newbies if they want to learn using core extensions.

Testing Instructions

Code review

@wilsonge wilsonge merged commit 9b910ec into joomla:4.0-dev Feb 17, 2020
@wilsonge
Copy link
Contributor

Makes sense to me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants