[4.0][RTL] CSS logical properties initial #28589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2020
C-Lodder
reviewed
Apr 6, 2020
|
@infograf768 can you test this please. If this works it will make maintaining RTL much easier. |
|
I have tested this item ✅ successfully on eb0d8bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28589. |
|
My tests were done with Firefox Macintosh |
|
Thank you @infograf768 |
|
Think the toolbar cleanup you did conflicted here. If you fix the conflicts happy to get this in |
|
Sorted. Once this is merged I will continue a cleanup across admin css. |
|
Thanks! |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jan 23, 2021
This css should have been removed a long time ago when @ciar4n changed the css in joomla#28589
wilsonge
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28546 .
Also removed some redundant rules ( #28586 & #28585).
Summary of Changes
Implements some logical properties to reduce on RTL CSS.
Testing Instructions
Apply this patch and run
node build.js --compile-cssto update SCSS. Check RTL styling.