Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix featured articles not shown in frontend #28632

Merged
merged 4 commits into from Apr 11, 2020
Merged

[4.0] Fix featured articles not shown in frontend #28632

merged 4 commits into from Apr 11, 2020

Conversation

SharkyKZ
Copy link
Contributor

Pull Request for Issue #28628.

Summary of Changes

Corrects dates in query when saving featured article.

Testing Instructions

Write an article, set is published and featured.
Make a Featured blog.

Expected result

The article is visible

Actual result

The article is not visible in the featured blog, but in a normal categoy blog

Documentation Changes Required

No.

@richard67
Copy link
Member

@SharkyKZ Drone reports PHPCS errors. Could you fix them?

@Harmageddon
Copy link
Contributor

I have tested this item ✅ successfully on e753b00

Works for me. For future testers: Note that the problem only occurs when creating a new article on an installation that doesn't include this patch. If you once have saved the article with a feature up date or with this PR, it will always correctly stay featured (unless you unfeature it), because it is correctly saved in the database.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

@richard67
Copy link
Member

Appveyor failure is a known issue not related to this PR, fix is in progress.

Drone PHPCS is ok now, other failure was maybe the randomly occuring issue, also not related to this PR ... just restarted drone, maybe we are lucky now.

@richard67
Copy link
Member

I have tested this item ✅ successfully on e753b00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 11, 2020
@wilsonge wilsonge merged commit 8effed8 into joomla:4.0-dev Apr 11, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 11, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 11, 2020
@SharkyKZ SharkyKZ deleted the j4/query/featured branch April 11, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants