New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Defer loading of menu items until required #28635
Conversation
I have tested this item ✅ successfully on f971e00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635. |
btw it seems that we have still an issue with PDO cause have worked even before this pr |
I have tested this item ✅ successfully on f971e00 dbtype mysqli Database Type mysql This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635. |
I have tested this item ✅ successfully on f971e00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@wilsonge Please wait a bit with merging, am just starting with tests ... even if it has already 2 good tests. But we should be very careful here. |
That's one of the PR's (update tests) where I am really happy about the update packages built by drone for this PR. In pasz I had to build them myself "manually". |
I have tested this item ✅ successfully on f971e00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635. |
Thankyou guys! |
Thank you guy 😛 |
drone and appveyor both failing. |
Appveyor is a known issue ... Hannes is on it. |
Please test #28647 for timeout issue. |
Pull Request for Issue #28614 .
Summary of Changes
Defers loading of the menu items until we actually need the information on the menu items. In certain cases this will mean that
Testing Instructions
Documentation Changes Required
Yes. Document menu items are being loaded later. This will only be relevant however for custom menus extending
Joomla\CMS\Menu\AbstractMenu
so should be an edge case.